This repository was archived by the owner on Mar 4, 2020. It is now read-only.
docs(menu): show disabled state for menu items in toolbar/submenu#933
Merged
codepretty merged 10 commits intomasterfrom Mar 8, 2019
Merged
docs(menu): show disabled state for menu items in toolbar/submenu#933codepretty merged 10 commits intomasterfrom
codepretty merged 10 commits intomasterfrom
Conversation
added 4 commits
February 19, 2019 12:17
codepretty
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
Codecov Report
@@ Coverage Diff @@
## master #933 +/- ##
=======================================
Coverage 81.66% 81.66%
=======================================
Files 677 677
Lines 8766 8766
Branches 1492 1558 +66
=======================================
Hits 7159 7159
Misses 1592 1592
Partials 15 15Continue to review full report at Codecov.
|
bmdalex
reviewed
Feb 21, 2019
packages/react/src/themes/teams/components/Icon/svg/icons/index.ts
Outdated
Show resolved
Hide resolved
bmdalex
approved these changes
Feb 28, 2019
layershifter
reviewed
Mar 4, 2019
docs/src/examples/components/Menu/Usages/MenuExampleToolbar.shorthand.tsx
Outdated
Show resolved
Hide resolved
layershifter
approved these changes
Mar 4, 2019
Member
layershifter
left a comment
layershifter
left a comment
There was a problem hiding this comment.
If Icon is exported, we should have a separate changelog entry
bmdalex
approved these changes
Mar 8, 2019
docs/src/examples/components/Menu/Variations/MenuExampleVertical.shorthand.tsx
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were no examples of a disabled menu for iconOnly and icon+text menu. I had requests from design to update the disabled color for icons, but the styling is correct. Adding as an example to the docs for a more complete example.
Updated menu as a toolbar example
