Skip to content

[Script] Fix #1652 by also checking for OperationCanceledException #1653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vnbaaij merged 1 commit into from
Mar 7, 2024
Merged

[Script] Fix #1652 by also checking for OperationCanceledException #1653

vnbaaij merged 1 commit into from
Mar 7, 2024

Conversation

@vnbaaij
Copy link
Collaborator

@vnbaaij vnbaaij commented Mar 7, 2024

Replace

catch (JSDisconnectedException)

with

catch (Exception ex) when (ex is JSDisconnectedException ||
                           ex is OperationCanceledException)

@vnbaaij vnbaaij merged commit acf444f into dev Mar 7, 2024
@vnbaaij vnbaaij deleted the users/vnbaaij/fix-issue-#1652 branch March 7, 2024 15:37
@vnbaaij vnbaaij changed the title [Misc] Fix #1652 by also checking for OperationCanceledException [Script] Fix #1652 by also checking for OperationCanceledException Mar 7, 2024
vnbaaij added a commit that referenced this pull request Mar 7, 2024
@vnbaaij
Fix #1652 by also checking for OperationCanceledException (#1653)
9557180
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dvoituron dvoituron dvoituron approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vnbaaij @dvoituron