Skip to content

Conversation

@rpodevns
Copy link
Contributor

@rpodevns rpodevns commented Feb 20, 2025

Pull Request

πŸ“– Description

Add CheckChanged EventCallback to FluentMenuItem and FluentMenu. Fix #3390

πŸ‘©β€πŸ’» Reviewer Notes

Not sure if this is the best approach so needing feedback for sure.

πŸ“‘ Test Plan

βœ… Checklist

General

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

Component-specific

  • I have added a new component
  • I have added Unit Tests for my new component
  • I have modified an existing component
  • I have validated the Unit Tests for an existing component

⏭ Next Steps

@vnbaaij
Copy link
Collaborator

vnbaaij commented Feb 23, 2025

@rpodevns Is this ready to go?

@rpodevns
Copy link
Contributor Author

rpodevns commented Feb 23, 2025

The manual tests I did seem to work fine. Did you have a chance to try it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: Add two-way databinding for Checked on FluentMenuItems

2 participants