-
Notifications
You must be signed in to change notification settings - Fork 460
[Menu] Add CheckedChanged EventCallback (fix 3390) #3414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
vnbaaij
merged 9 commits into
microsoft:dev
from
rpodevns:feature/3390-menuitem-checked-changed
Feb 25, 2025
Merged
[Menu] Add CheckedChanged EventCallback (fix 3390) #3414
vnbaaij
merged 9 commits into
microsoft:dev
from
rpodevns:feature/3390-menuitem-checked-changed
Feb 25, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpodevns
commented
Feb 20, 2025
vnbaaij
requested changes
Feb 21, 2025
vnbaaij
approved these changes
Feb 22, 2025
Collaborator
|
@rpodevns Is this ready to go? |
Contributor
Author
|
The manual tests I did seem to work fine. Did you have a chance to try it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
π Description
Add CheckChanged EventCallback to FluentMenuItem and FluentMenu. Fix #3390
π©βπ» Reviewer Notes
Not sure if this is the best approach so needing feedback for sure.
π Test Plan
β Checklist
General
Component-specific
β Next Steps