[Toolbar] Dispose of JS module properly #3470
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
The FluentToolbar component does not gracefully fail when the circuit is disconnected, unlike other components. All this PR does is ignore the common disposal exceptions that aren't actually errors.
@vnbaaij
🎫 Issues
Bug introduced in https://github.com/microsoft/fluentui-blazor/pull/3200/files#diff-c46cfdab564549443ae663c4d78f9bddc88ce16058ea6e4613572fd51a27ad7d
👩💻 Reviewer Notes
📑 Test Plan
✅ Checklist
General
Component-specific
⏭ Next Steps