Skip to content

Conversation

@adamint
Copy link
Member

@adamint adamint commented Mar 4, 2025

Pull Request

📖 Description

The FluentToolbar component does not gracefully fail when the circuit is disconnected, unlike other components. All this PR does is ignore the common disposal exceptions that aren't actually errors.

@vnbaaij

🎫 Issues

Bug introduced in https://github.com/microsoft/fluentui-blazor/pull/3200/files#diff-c46cfdab564549443ae663c4d78f9bddc88ce16058ea6e4613572fd51a27ad7d

👩‍💻 Reviewer Notes

📑 Test Plan

✅ Checklist

General

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

Component-specific

  • I have added a new component
  • I have added Unit Tests for my new component
  • I have modified an existing component
  • I have validated the Unit Tests for an existing component

⏭ Next Steps

@vnbaaij vnbaaij changed the title Dispose fluent toolbar module properly [Toolbar] Dispose of JS module properly Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants