-
Notifications
You must be signed in to change notification settings - Fork 461
[Wizard] Add the ability to invoke OnFinish
#3648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Wizard] Add the ability to invoke OnFinish
#3648
Conversation
|
That could be a good additional method. For the Unit Tests, you need take inspiration from |
|
@dvoituron - I've added the following 3 unit tests as requested: |
OnFinish
Pull Request
📖 Description
The
FluentWizardcurrently allows you to customize theButtonTemplatewhich is great! And there is a public method exposed (GoToStepAsync) which allows you to essentially call theNextandPreviousbuttons manually from your custom buttons. However, there is no way to call theOnFinishlogic from a custom button. This updates the component to expose a new method calledFinishAsyncwith an optional parameter to validate the form contexts (which I modeled after theGoToStepAsyncmethod).I am not sure if/how you would like me to add unit tests for this. There are not any unit tests currently for the 'Customized'
ButtonTemplateportion of the FluentWizard. I ran all the current unit tests to ensure that nothing broke. If you would like a unit test added, please specify what the unit test should be doing so that I know how you would like it written and what it would be testing.👩💻 Reviewer Notes
I have updated the demo site page to include a new
Finishbutton on the "Customized Wizard" area.✅ Checklist
General
Component-specific