-
Notifications
You must be signed in to change notification settings - Fork 460
[AutoComplete] Add OptionComparer to prevent duplicate items from different object instances (#3881) #3882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
[AutoComplete] Add OptionComparer to prevent duplicate items from different object instances (#3881) #3882
Changes from 6 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
ee11783
Add check for internal list to determine if an item has already been …
MarvinKlein1508 007937d
Update code comment
MarvinKlein1508 fea6bf6
Add demo for autocomplete with different object instances
MarvinKlein1508 e02e838
Add unit test
MarvinKlein1508 2be6c78
Clear IssueTester
MarvinKlein1508 e6b0dfa
Merge branch 'dev' into fix-two-instances
vnbaaij 72fc933
Use IEqualityComparer<TOption> instead of Func<TOption, TOption, bool>
MarvinKlein1508 5884195
Merge branch 'fix-two-instances' of https://github.com/MarvinKlein150…
MarvinKlein1508 036742e
Update demo description for OptionComparer
MarvinKlein1508 e91c6ab
Update documentation
MarvinKlein1508 dea8f7c
Add unit test for FluentSelect
MarvinKlein1508 13dea63
Add unit test for FluentListBox
MarvinKlein1508 8f24007
Code review fixes
MarvinKlein1508 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
49 changes: 49 additions & 0 deletions
49
...s/Demo/Shared/Pages/List/Autocomplete/Examples/AutocompleteDifferentObjectInstances.razor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| <FluentStack> | ||
| <div> | ||
| Without <code>OptionComparer</code>: | ||
| <FluentAutocomplete TOption="SimplePerson" | ||
| Label="Users" | ||
| Class="w-100" | ||
| Placeholder="Name" | ||
| OnOptionsSearch="@OnSearchUserAsync" | ||
| OptionText="@(item => $"{item.Firstname} {item.Lastname}" )" | ||
| @bind-SelectedOptions="Users1" /> | ||
| </div> | ||
| <div> | ||
| With <code>OptionComparer</code>: | ||
| <FluentAutocomplete TOption="SimplePerson" | ||
| Label="Users" | ||
| Class="w-100" | ||
| Placeholder="Name" | ||
| OnOptionsSearch="@OnSearchUserAsync" | ||
| OptionComparer="IsOptionAdded" | ||
| OptionText="@(item => $"{item.Firstname} {item.Lastname}" )" | ||
| @bind-SelectedOptions="Users2" /> | ||
| </div> | ||
| </FluentStack> | ||
| @code { | ||
|
|
||
| public IEnumerable<SimplePerson> Users1 { get; set; } = [new SimplePerson { Firstname = "Marvin", Lastname = "Klein", Age = 28 }]; | ||
| public IEnumerable<SimplePerson> Users2 { get; set; } = [new SimplePerson { Firstname = "Marvin", Lastname = "Klein", Age = 28 }]; | ||
|
|
||
| private bool IsOptionAdded(SimplePerson listItem, SimplePerson selectedItem) | ||
| { | ||
| // Compare both objects with each other to determine if they are equal | ||
| return listItem.Firstname == selectedItem.Firstname && listItem.Lastname == selectedItem.Lastname; | ||
| } | ||
|
|
||
| private Task OnSearchUserAsync(OptionsSearchEventArgs<SimplePerson> e) | ||
| { | ||
| // Simulate new instances for every search. Typically you would retrieve these from a database or an API. | ||
| var results = new List<SimplePerson> | ||
| { | ||
| new SimplePerson { Firstname = "Alice", Lastname = "Wonder", Age = 31 }, | ||
| new SimplePerson { Firstname = "Marvin", Lastname = "Klein", Age = 28 }, | ||
| new SimplePerson { Firstname = "Vincent", Lastname = "Baaji", Age = 38 }, | ||
| }; | ||
|
|
||
| e.Items = results; | ||
|
|
||
| return Task.CompletedTask; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.