Skip to content

Conversation

@Tyme-Bleyaert
Copy link
Collaborator

Pull Request

πŸ“– Description

Fix for not applying custom classes.

🎫 Issues

#4205

βœ… Checklist

General

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

Component-specific

  • I have added a new component
  • I have added Unit Tests for my new component
  • I have modified an existing component
  • I have validated the Unit Tests for an existing component

@Tyme-Bleyaert
Copy link
Collaborator Author

TODO: write unit test to prevent this from happing in the future.

Gonna do that this evening, but just so i don't forget.

@vnbaaij
Copy link
Collaborator

vnbaaij commented Oct 3, 2025

@Tyme-Bleyaert in dev-v5 branch we already have tests in place that checks and test components on all the shared/standard parameters/properties like Id, Class, Style etc. Not really worthwhile to add them to v4 anymore, I think,

@Tyme-Bleyaert Tyme-Bleyaert marked this pull request as ready for review October 3, 2025 12:45
@vnbaaij vnbaaij merged commit b03ed14 into microsoft:dev Oct 3, 2025
2 of 3 checks passed
@vnbaaij vnbaaij changed the title [FluentPaginator] Fix for not applying custom classes [Paginator] Fix for not applying custom classes Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants