Skip to content

Prevent multiple FocusTrapZones from causing an infinite loop#1111

Merged
dzearing merged 7 commits intomicrosoft:masterfrom
dagoff:dagoff/focusTrapZone2
Mar 2, 2017
Merged

Prevent multiple FocusTrapZones from causing an infinite loop#1111
dzearing merged 7 commits intomicrosoft:masterfrom
dagoff:dagoff/focusTrapZone2

Conversation

@dagoff
Copy link
Member

@dagoff dagoff commented Feb 24, 2017

Pull request checklist

  • Addresses an existing issue: #0000
  • Include a change request file if publishing
  • New feature, bugfix, or enhancement
    • Includes tests
  • Documentation update

Description of changes

Prevent multiple FocusTrapZones from causing an infinite loop.

Focus areas to test

(optional)

@msftclas
Copy link

@dagoff,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@dzearing dzearing merged commit a40d24f into microsoft:master Mar 2, 2017
aleksandrjPersonal pushed a commit to aleksandrjPersonal/office-ui-fabric-react that referenced this pull request Mar 10, 2017
…oft#1111)

* Prevent multiple FocusTrapZones from causing an infinite loop

* Rush change

* FocusTrapZone checks the wrong side of the priorityStack

* Fix bug related to default parameters

* Track clicks seperately

* Add FocusTrapZone demo showing off nested behavior

* Update dagoff-focusTrapZone_2017-02-23-22-47.json
aleksandrjPersonal pushed a commit to aleksandrjPersonal/office-ui-fabric-react that referenced this pull request Mar 10, 2017
…oft#1111)

* Prevent multiple FocusTrapZones from causing an infinite loop

* Rush change

* FocusTrapZone checks the wrong side of the priorityStack

* Fix bug related to default parameters

* Track clicks seperately

* Add FocusTrapZone demo showing off nested behavior

* Update dagoff-focusTrapZone_2017-02-23-22-47.json
aleksandrjPersonal pushed a commit to aleksandrjPersonal/office-ui-fabric-react that referenced this pull request Mar 10, 2017
…oft#1111)

* Prevent multiple FocusTrapZones from causing an infinite loop

* Rush change

* FocusTrapZone checks the wrong side of the priorityStack

* Fix bug related to default parameters

* Track clicks seperately

* Add FocusTrapZone demo showing off nested behavior

* Update dagoff-focusTrapZone_2017-02-23-22-47.json
aleksandrjPersonal pushed a commit to aleksandrjPersonal/office-ui-fabric-react that referenced this pull request Mar 10, 2017
…oft#1111)

* Prevent multiple FocusTrapZones from causing an infinite loop

* Rush change

* FocusTrapZone checks the wrong side of the priorityStack

* Fix bug related to default parameters

* Track clicks seperately

* Add FocusTrapZone demo showing off nested behavior

* Update dagoff-focusTrapZone_2017-02-23-22-47.json
@microsoft microsoft locked as resolved and limited conversation to collaborators Aug 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants