chore: Moving ToolbarMenuItem to be functional component#12120
Merged
layershifter merged 5 commits intomicrosoft:masterfrom Feb 28, 2020
Merged
chore: Moving ToolbarMenuItem to be functional component#12120layershifter merged 5 commits intomicrosoft:masterfrom
layershifter merged 5 commits intomicrosoft:masterfrom
Conversation
pompomon
requested review from
JasonGore,
dzearing,
ecraig12345,
jdhuntington,
kenotron,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
msft-github-bot
added
the
Fluent UI react-northstar (v0)
Contributor
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 5366fcd5f97f1bd8117509e67dfdca7157d744aa (build) |
silviuaavram
approved these changes
Feb 28, 2020
packages/fluentui/react/src/components/Toolbar/ToolbarMenuItem.tsx
Outdated
Show resolved
Hide resolved
layershifter
approved these changes
Feb 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeBreaking changes
This PR converts
ToolbarMenuItemcomponent to be functional. As in all other cases it contains a breaking change with restricted props set that will be passed to styles functions.Microsoft Reviewers: Open in CodeFlow