makeStyles: finish up keyframes implementation#16757
Merged
xugao merged 7 commits intomicrosoft:masterfrom Feb 3, 2021
Merged
Conversation
xugao
commented
Feb 2, 2021
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 434b0dd:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 6adb69ffc5187cadeb9ecfdb5280fa6f027d6546 (build) |
Collaborator
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
layershifter
reviewed
Feb 2, 2021
layershifter
reviewed
Feb 2, 2021
layershifter
reviewed
Feb 2, 2021
layershifter
reviewed
Feb 2, 2021
layershifter
reviewed
Feb 2, 2021
layershifter
reviewed
Feb 2, 2021
| const animationName = names.join(' '); | ||
| const animationNameRtl = namesRtl.join(' '); | ||
| result[animationName] = [undefined, keyframeCSS, keyframeRtlCSS || undefined]; | ||
| resolveStyleRules({ animationName }, unstable_cssPriority, pseudo, media, support, result, animationNameRtl); |
Member
There was a problem hiding this comment.
I would like to have a better proposal than adding animationNameRtl as a param, but nothing simpler comes to my mind 💭
Contributor
Author
There was a problem hiding this comment.
I didn't like this either. I will think a bit more :)
Contributor
Author
There was a problem hiding this comment.
I thought about this more today but couldn't come up with a better approach :/
layershifter
reviewed
Feb 2, 2021
layershifter
reviewed
Feb 2, 2021
xugao
force-pushed
the
makestyles-keyframes-2
branch
from
b097cf1 to
434b0dd
Compare
layershifter
approved these changes
Feb 3, 2021
Collaborator
|
🎉 Handy links: |
This was referenced Feb 4, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
Finish up
keyframesimplementation inmakeStyles, including:Related issue: #16372
Focus areas to test
Added unit tests.