rfc: Global styles (normalize)#17561
Closed
miroslavstastny wants to merge 2 commits intomicrosoft:masterfrom
Closed
rfc: Global styles (normalize)#17561miroslavstastny wants to merge 2 commits intomicrosoft:masterfrom
miroslavstastny wants to merge 2 commits intomicrosoft:masterfrom
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 7d6c6d2:
|
Collaborator
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
Asset size changes
Baseline commit: 816ce1e01693083e6e651f4b2f3912acc5dd6832 (build) |
|
|
||
| ## Open Issues | ||
|
|
||
| - Where will the `CSSBaseline` component take the `window` from? If from context, then it must be inside a `Provider` tree. |
Member
There was a problem hiding this comment.
I would say that CSSBaseline should be rendered inside a Provider always: it's required by makeStaticStyles() to render into proper document.
layershifter
approved these changes
Mar 29, 2021
Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com>
22 tasks
Member
Author
|
On hold, discussing with partners. |
Collaborator
|
Because this pull request has not had activity for over 150 days, we're automatically closing it for house-keeping purposes. The pull request will still be available for reference. If it's still relevant to merge at some point, you can reopen or make a new version based on the latest code. |
msft-fluent-ui-bot
added
the
Resolution: Soft Close
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This RFC proposes how those global styles will be injected into DOM.
global-styles.md