(chore) Move react-input, react-label, react-link to react-components subfolder by TristanWatanabe · Pull Request #22694 · microsoft/fluentui

TristanWatanabe · 2022-04-28T13:55:22Z

Changes

Moves @fluentui/react-input, @fluentui/react-label and @fluentui/react-link to react-components common folder using move-packages nx generator.

Related Issue(s)

Part of #22427

codesandbox-ci · 2022-04-28T14:02:55Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 87989a0:

Sandbox	Source
@fluentui/react 8 starter	Configuration
@fluentui/react-components 9 starter	Configuration

fabricteam · 2022-04-28T14:08:13Z

Perf Analysis (`@fluentui/react-components`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
Avatar	mount	1085	1073	5000
Button	mount	651	676	5000
FluentProvider	mount	2177	2193	5000
FluentProviderWithTheme	mount	322	341	10
FluentProviderWithTheme	virtual-rerender	259	274	10
FluentProviderWithTheme	virtual-rerender-with-unmount	363	358	10
MakeStyles	mount	1823	1833	50000

size-auditor · 2022-04-28T14:08:46Z

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 5842ed56a87ffcd6aa607cd98d3c95087221f017 (build)

fabricteam · 2022-04-28T14:14:14Z

📊 Bundle size report

Unchanged fixtures

Package & Exports	Size (minified/GZIP)
`priority-overflow` createOverflowManager	`2.936 kB` `1.212 kB`
`react-accordion` Accordion (including children components)	`73.754 kB` `22.494 kB`
`react-badge` Badge	`20.965 kB` `6.605 kB`
`react-badge` CounterBadge	`21.918 kB` `6.919 kB`
`react-badge` PresenceBadge	`22.005 kB` `6.582 kB`
`react-combobox` Combobox	`60.564 kB` `20.751 kB`
`react-divider` Divider	`15.455 kB` `5.57 kB`
`react-overflow` hooks only	`10.792 kB` `4.125 kB`
`react-positioning` usePopper	`23.21 kB` `8.084 kB`
`react-radio` Radio	`23.488 kB` `7.889 kB`
`react-radio` RadioGroup	`8.205 kB` `3.516 kB`
`react-spinbutton` SpinButton	`41.955 kB` `11.856 kB`
`react-spinner` Spinner	`17.224 kB` `5.856 kB`
`react-switch` Switch	`24.333 kB` `8.019 kB`
`react-text` Text - Default	`10.867 kB` `4.269 kB`
`react-text` Text - Wrappers	`14.183 kB` `4.61 kB`
`react-textarea` Textarea	`20.672 kB` `7.07 kB`
`react-theme` Single theme token import	`69 B` `89 B`
`react-theme` Teams: all themes	`31.327 kB` `7.041 kB`
`react-theme` Teams: Light theme	`19.772 kB` `5.698 kB`
`react-tooltip` Tooltip	`42.907 kB` `14.761 kB`
`react-utilities` SSRProvider	`189 B` `161 B`

_{🤖 This report was generated against 5842ed56a87ffcd6aa607cd98d3c95087221f017}

fabricteam · 2022-04-28T14:16:30Z

Perf Analysis (`@fluentui/react-northstar`)

Perf tests with no regressions

Scenario	Current PR Ticks	Baseline Ticks	Ratio
CarouselMinimalPerf.default	523	469	1.12:1
ButtonSlotsPerf.default	578	525	1.1:1
ChatWithPopoverPerf.default	410	380	1.08:1
BoxMinimalPerf.default	359	337	1.07:1
DividerMinimalPerf.default	361	339	1.06:1
LayoutMinimalPerf.default	368	346	1.06:1
AccordionMinimalPerf.default	151	144	1.05:1
ChatDuplicateMessagesPerf.default	295	281	1.05:1
LoaderMinimalPerf.default	719	685	1.05:1
MenuMinimalPerf.default	884	839	1.05:1
DialogMinimalPerf.default	790	762	1.04:1
FormMinimalPerf.default	406	392	1.04:1
TreeWith60ListItems.default	181	174	1.04:1
AnimationMinimalPerf.default	555	537	1.03:1
RadioGroupMinimalPerf.default	456	444	1.03:1
RefMinimalPerf.default	247	240	1.03:1
SkeletonMinimalPerf.default	347	336	1.03:1
SplitButtonMinimalPerf.default	4530	4389	1.03:1
CardMinimalPerf.default	562	549	1.02:1
DatepickerMinimalPerf.default	6235	6115	1.02:1
LabelMinimalPerf.default	375	366	1.02:1
ListNestedPerf.default	573	560	1.02:1
SegmentMinimalPerf.default	349	343	1.02:1
TableManyItemsPerf.default	1947	1917	1.02:1
TextAreaMinimalPerf.default	495	484	1.02:1
ButtonOverridesMissPerf.default	1525	1506	1.01:1
EmbedMinimalPerf.default	4185	4133	1.01:1
InputMinimalPerf.default	1344	1328	1.01:1
ItemLayoutMinimalPerf.default	1220	1209	1.01:1
PortalMinimalPerf.default	172	170	1.01:1
IconMinimalPerf.default	621	612	1.01:1
ToolbarMinimalPerf.default	976	971	1.01:1
AttachmentSlotsPerf.default	1100	1105	1:1
CheckboxMinimalPerf.default	2735	2735	1:1
GridMinimalPerf.default	337	337	1:1
HeaderSlotsPerf.default	757	758	1:1
ListCommonPerf.default	633	632	1:1
ListMinimalPerf.default	508	509	1:1
MenuButtonMinimalPerf.default	1712	1719	1:1
PopupMinimalPerf.default	628	626	1:1
ProviderMinimalPerf.default	407	406	1:1
ReactionMinimalPerf.default	372	372	1:1
StatusMinimalPerf.default	665	668	1:1
TableMinimalPerf.default	409	408	1:1
TextMinimalPerf.default	340	340	1:1
CustomToolbarPrototype.default	2830	2843	1:1
TreeMinimalPerf.default	822	825	1:1
VideoMinimalPerf.default	655	655	1:1
AlertMinimalPerf.default	267	269	0.99:1
ChatMinimalPerf.default	754	763	0.99:1
DropdownMinimalPerf.default	3061	3096	0.99:1
RosterPerf.default	1126	1140	0.99:1
SliderMinimalPerf.default	1684	1697	0.99:1
FlexMinimalPerf.default	283	290	0.98:1
HeaderMinimalPerf.default	352	361	0.98:1
ImageMinimalPerf.default	363	372	0.98:1
AttachmentMinimalPerf.default	153	157	0.97:1
DropdownManyItemsPerf.default	675	695	0.97:1
ListWith60ListItems.default	652	671	0.97:1
TooltipMinimalPerf.default	1058	1095	0.97:1
ProviderMergeThemesPerf.default	1253	1326	0.94:1
AvatarMinimalPerf.default	179	193	0.93:1
ButtonMinimalPerf.default	158	172	0.92:1

fabricteam · 2022-04-28T14:26:48Z

Perf Analysis (`@fluentui/react`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
BaseButton	mount	710	744	5000
Breadcrumb	mount	2106	2099	1000
Checkbox	mount	1221	1168	5000
CheckboxBase	mount	1003	1071	5000
ChoiceGroup	mount	3663	3697	5000
ComboBox	mount	795	790	1000
CommandBar	mount	8304	8971	1000
ContextualMenu	mount	9671	9250	1000
DefaultButton	mount	900	972	5000
DetailsRow	mount	3174	3131	5000
DetailsRowFast	mount	3137	3037	5000
DetailsRowNoStyles	mount	2948	2861	5000
Dialog	mount	1848	1738	1000
DocumentCardTitle	mount	130	133	1000
Dropdown	mount	2719	2522	5000
FocusTrapZone	mount	1533	1470	5000
FocusZone	mount	1457	1475	5000
IconButton	mount	1455	1342	5000
Label	mount	277	269	5000
Layer	mount	2427	2260	5000
Link	mount	368	386	5000
MenuButton	mount	1212	1168	5000
MessageBar	mount	1575	1762	5000
Nav	mount	2702	2657	1000
OverflowSet	mount	895	860	5000
Panel	mount	1746	1790	1000
Persona	mount	764	810	1000
Pivot	mount	1116	1155	1000
PrimaryButton	mount	1062	1012	5000
Rating	mount	6110	6210	5000
SearchBox	mount	999	1058	5000
Shimmer	mount	2075	2001	5000
Slider	mount	1651	1472	5000
SpinButton	mount	4243	4280	5000
Spinner	mount	321	327	5000
SplitButton	mount	2514	2486	5000
Stack	mount	443	406	5000
StackWithIntrinsicChildren	mount	1788	1870	5000
StackWithTextChildren	mount	4121	4239	5000
SwatchColorPicker	mount	9103	9369	5000
TagPicker	mount	2181	2098	5000
TeachingBubble	mount	77423	77986	5000
Text	mount	366	321	5000
TextField	mount	1174	1103	5000
ThemeProvider	mount	1019	899	5000
ThemeProvider	virtual-rerender	561	493	5000
ThemeProvider	virtual-rerender-with-unmount	1501	1500	5000
Toggle	mount	641	641	5000
buttonNative	mount	91	109	5000

ghost · 2022-04-29T11:55:29Z

All CLA requirements met.

… subfolder (microsoft#22694)

TristanWatanabe added 3 commits April 28, 2022 06:48

move react-input

60f0e15

move react-label

efd366b

move react-link

d3edd5f

TristanWatanabe added the Area: Build System label Apr 28, 2022

TristanWatanabe self-assigned this Apr 28, 2022

TristanWatanabe requested review from a team, JustSlone, jurokapsiar and khmakoto as code owners April 28, 2022 13:55

TristanWatanabe mentioned this pull request Apr 28, 2022

group vNext to common folder (as people will start check vNext) #22427

Closed

23 tasks

Change Files

b4bd37c

JustSlone approved these changes Apr 28, 2022

View reviewed changes

Merge branch 'master' into move-cxe-red-pkgs-batch-2

ac984d2

sopranopillow approved these changes Apr 28, 2022

View reviewed changes

khmakoto approved these changes Apr 28, 2022

View reviewed changes

spmonahan approved these changes Apr 28, 2022

View reviewed changes

Merge branch 'master' into move-cxe-red-pkgs-batch-2

87989a0

tudorpopams requested a review from Hotell April 29, 2022 12:14

Hotell approved these changes Apr 29, 2022

View reviewed changes

TristanWatanabe merged commit 88fa8f2 into microsoft:master Apr 29, 2022

TristanWatanabe deleted the move-cxe-red-pkgs-batch-2 branch April 29, 2022 12:36

marwan38 pushed a commit to marwan38/fluentui that referenced this pull request Jun 13, 2022

(chore) Move react-input, react-label, react-link to react-components…

df83449

… subfolder (microsoft#22694)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

(chore) Move react-input, react-label, react-link to react-components subfolder#22694

(chore) Move react-input, react-label, react-link to react-components subfolder#22694
TristanWatanabe merged 6 commits intomicrosoft:masterfrom
TristanWatanabe:move-cxe-red-pkgs-batch-2

TristanWatanabe commented Apr 28, 2022

Uh oh!

codesandbox-ci bot commented Apr 28, 2022 •

edited

Loading

Uh oh!

fabricteam commented Apr 28, 2022 •

edited

Loading

Uh oh!

size-auditor bot commented Apr 28, 2022 •

edited

Loading

Uh oh!

fabricteam commented Apr 28, 2022 •

edited

Loading

Uh oh!

fabricteam commented Apr 28, 2022 •

edited

Loading

Uh oh!

fabricteam commented Apr 28, 2022 •

edited

Loading

Uh oh!

ghost commented Apr 29, 2022 •

edited by ghost

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Conversation

TristanWatanabe commented Apr 28, 2022

Changes

Related Issue(s)

Uh oh!

codesandbox-ci bot commented Apr 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fabricteam commented Apr 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf Analysis (@fluentui/react-components)

Uh oh!

size-auditor bot commented Apr 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Asset size changes

Uh oh!

fabricteam commented Apr 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Bundle size report

Uh oh!

fabricteam commented Apr 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf Analysis (@fluentui/react-northstar)

Uh oh!

fabricteam commented Apr 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf Analysis (@fluentui/react)

Uh oh!

ghost commented Apr 29, 2022 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

codesandbox-ci bot commented Apr 28, 2022 •

edited

Loading

fabricteam commented Apr 28, 2022 •

edited

Loading

Perf Analysis (`@fluentui/react-components`)

size-auditor bot commented Apr 28, 2022 •

edited

Loading

fabricteam commented Apr 28, 2022 •

edited

Loading

fabricteam commented Apr 28, 2022 •

edited

Loading

Perf Analysis (`@fluentui/react-northstar`)

fabricteam commented Apr 28, 2022 •

edited

Loading

Perf Analysis (`@fluentui/react`)

ghost commented Apr 29, 2022 •

edited by ghost

Loading