(chore) Move react-combobox to react-components subfolder by TristanWatanabe · Pull Request #22830 · microsoft/fluentui

TristanWatanabe · 2022-05-04T15:14:16Z

Changes

Moves @fluentui/react-combobox to react-components common folder using move-packages nx generator.

Related Issue(s)

Part of #22427

codesandbox-ci · 2022-05-04T15:21:01Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6dbc64d:

Sandbox	Source
@fluentui/react 8 starter	Configuration
@fluentui/react-components 9 starter	Configuration

size-auditor · 2022-05-04T15:27:12Z

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 2769e4b68c65eb8e06cf15384f51059e819b1fc5 (build)

fabricteam · 2022-05-04T15:27:26Z

Perf Analysis (`@fluentui/react-components`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
Avatar	mount	1108	1070	5000
Button	mount	655	650	5000
FluentProvider	mount	2271	2220	5000
FluentProviderWithTheme	mount	342	313	10
FluentProviderWithTheme	virtual-rerender	271	250	10
FluentProviderWithTheme	virtual-rerender-with-unmount	353	347	10
MakeStyles	mount	1843	1864	50000

fabricteam · 2022-05-04T15:32:58Z

📊 Bundle size report

Package & Exports	Baseline (minified/GZIP)	PR	Change
`react-combobox` Combobox	`60.892 kB` `20.814 kB`	`60.892 kB` `20.813 kB`	`-1 B`

Unchanged fixtures

Package & Exports	Size (minified/GZIP)
`priority-overflow` createOverflowManager	`2.936 kB` `1.212 kB`
`react-accordion` Accordion (including children components)	`73.834 kB` `22.534 kB`
`react-avatar` Avatar	`45.51 kB` `13.25 kB`
`react-badge` Badge	`21.1 kB` `6.671 kB`
`react-badge` CounterBadge	`22.015 kB` `6.976 kB`
`react-badge` PresenceBadge	`22.346 kB` `6.715 kB`
`react-button` Button	`32.591 kB` `9.056 kB`
`react-button` CompoundButton	`38.836 kB` `10.221 kB`
`react-button` MenuButton	`34.381 kB` `9.645 kB`
`react-button` SplitButton	`41.662 kB` `10.95 kB`
`react-button` ToggleButton	`43.518 kB` `9.984 kB`
`react-card` Card - All	`59.102 kB` `16.957 kB`
`react-card` Card	`54.387 kB` `15.706 kB`
`react-card` CardFooter	`7.891 kB` `3.363 kB`
`react-card` CardHeader	`9.463 kB` `3.881 kB`
`react-card` CardPreview	`7.863 kB` `3.391 kB`
`react-components` react-components: Accordion, Button, FluentProvider, Image, Menu, Popover	`179.74 kB` `50.168 kB`
`react-components` react-components: FluentProvider & webLightTheme	`34.178 kB` `11.138 kB`
`react-divider` Divider	`15.65 kB` `5.636 kB`
`react-image` Image	`10.314 kB` `4.06 kB`
`react-input` Input	`22.274 kB` `7.336 kB`
`react-label` Label	`8.644 kB` `3.614 kB`
`react-link` Link	`11.52 kB` `4.69 kB`
`react-menu` Menu (including children components)	`110.335 kB` `33.584 kB`
`react-menu` Menu (including selectable components)	`113.51 kB` `34.053 kB`
`react-overflow` hooks only	`10.792 kB` `4.124 kB`
`react-popover` Popover	`101.258 kB` `30.847 kB`
`react-portal` Portal	`6.272 kB` `2.17 kB`
`react-positioning` usePopper	`23.21 kB` `8.084 kB`
`react-provider` FluentProvider	`14.227 kB` `5.336 kB`
`react-radio` Radio	`29.568 kB` `10.122 kB`
`react-radio` RadioGroup	`13.751 kB` `5.515 kB`
`react-select` Select	`17.176 kB` `6.408 kB`
`react-slider` Slider	`25.657 kB` `8.302 kB`
`react-spinbutton` SpinButton	`41.985 kB` `11.908 kB`
`react-spinner` Spinner	`17.895 kB` `5.988 kB`
`react-switch` Switch	`25.539 kB` `8.286 kB`
`react-text` Text - Default	`11.002 kB` `4.336 kB`
`react-text` Text - Wrappers	`14.324 kB` `4.749 kB`
`react-textarea` Textarea	`21.318 kB` `7.211 kB`
`react-theme` Single theme token import	`69 B` `89 B`
`react-theme` Teams: all themes	`31.363 kB` `7.043 kB`
`react-theme` Teams: Light theme	`19.806 kB` `5.699 kB`
`react-tooltip` Tooltip	`43.039 kB` `14.819 kB`
`react-utilities` SSRProvider	`189 B` `161 B`

_{🤖 This report was generated against 2769e4b68c65eb8e06cf15384f51059e819b1fc5}

fabricteam · 2022-05-04T15:35:12Z

Perf Analysis (`@fluentui/react-northstar`)

Perf tests with no regressions

Scenario	Current PR Ticks	Baseline Ticks	Ratio
IconMinimalPerf.default	524	457	1.15:1
RosterPerf.default	962	876	1.1:1
AccordionMinimalPerf.default	119	110	1.08:1
AnimationMinimalPerf.default	454	420	1.08:1
AttachmentMinimalPerf.default	133	125	1.06:1
ProviderMergeThemesPerf.default	1029	973	1.06:1
TableMinimalPerf.default	331	311	1.06:1
CarouselMinimalPerf.default	403	383	1.05:1
HeaderSlotsPerf.default	652	623	1.05:1
LoaderMinimalPerf.default	572	545	1.05:1
ButtonMinimalPerf.default	145	139	1.04:1
ProviderMinimalPerf.default	339	325	1.04:1
ReactionMinimalPerf.default	321	310	1.04:1
FlexMinimalPerf.default	246	238	1.03:1
ItemLayoutMinimalPerf.default	1013	987	1.03:1
MenuMinimalPerf.default	718	696	1.03:1
PortalMinimalPerf.default	148	143	1.03:1
RefMinimalPerf.default	204	199	1.03:1
DropdownManyItemsPerf.default	575	562	1.02:1
EmbedMinimalPerf.default	3494	3430	1.02:1
GridMinimalPerf.default	277	271	1.02:1
ListMinimalPerf.default	442	433	1.02:1
SegmentMinimalPerf.default	291	285	1.02:1
CheckboxMinimalPerf.default	2290	2259	1.01:1
DividerMinimalPerf.default	295	292	1.01:1
FormMinimalPerf.default	329	325	1.01:1
ImageMinimalPerf.default	312	309	1.01:1
ListWith60ListItems.default	549	545	1.01:1
SplitButtonMinimalPerf.default	3699	3676	1.01:1
CustomToolbarPrototype.default	2325	2301	1.01:1
ButtonSlotsPerf.default	450	451	1:1
DialogMinimalPerf.default	650	652	1:1
PopupMinimalPerf.default	527	525	1:1
RadioGroupMinimalPerf.default	366	365	1:1
AvatarMinimalPerf.default	160	162	0.99:1
BoxMinimalPerf.default	275	279	0.99:1
ButtonOverridesMissPerf.default	1267	1286	0.99:1
LabelMinimalPerf.default	311	314	0.99:1
MenuButtonMinimalPerf.default	1391	1401	0.99:1
TooltipMinimalPerf.default	948	962	0.99:1
AttachmentSlotsPerf.default	896	910	0.98:1
DropdownMinimalPerf.default	2503	2557	0.98:1
InputMinimalPerf.default	1063	1084	0.98:1
LayoutMinimalPerf.default	299	305	0.98:1
SliderMinimalPerf.default	1421	1457	0.98:1
TextMinimalPerf.default	282	287	0.98:1
TextAreaMinimalPerf.default	403	412	0.98:1
ChatWithPopoverPerf.default	318	327	0.97:1
StatusMinimalPerf.default	541	557	0.97:1
ChatMinimalPerf.default	589	614	0.96:1
ListCommonPerf.default	515	539	0.96:1
TreeMinimalPerf.default	654	679	0.96:1
TreeWith60ListItems.default	136	141	0.96:1
ToolbarMinimalPerf.default	752	791	0.95:1
ListNestedPerf.default	447	475	0.94:1
VideoMinimalPerf.default	505	537	0.94:1
CardMinimalPerf.default	430	465	0.92:1
HeaderMinimalPerf.default	266	291	0.91:1
SkeletonMinimalPerf.default	258	284	0.91:1
ChatDuplicateMessagesPerf.default	214	245	0.87:1
AlertMinimalPerf.default	190	222	0.86:1
DatepickerMinimalPerf.default	4863	5836	0.83:1
TableManyItemsPerf.default	1611	3812	0.42:1

fabricteam · 2022-05-04T15:39:56Z

Perf Analysis (`@fluentui/react`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
BaseButton	mount	948	929	5000
Breadcrumb	mount	2789	2768	1000
Checkbox	mount	1521	1562	5000
CheckboxBase	mount	1286	1346	5000
ChoiceGroup	mount	4801	4818	5000
ComboBox	mount	1001	1022	1000
CommandBar	mount	10830	10908	1000
ContextualMenu	mount	11928	11894	1000
DefaultButton	mount	1151	1169	5000
DetailsRow	mount	3972	4018	5000
DetailsRowFast	mount	3957	4005	5000
DetailsRowNoStyles	mount	3729	3749	5000
Dialog	mount	2336	2311	1000
DocumentCardTitle	mount	164	177	1000
Dropdown	mount	3394	3393	5000
FocusTrapZone	mount	1908	1881	5000
FocusZone	mount	1874	1898	5000
IconButton	mount	1811	1816	5000
Label	mount	348	357	5000
Layer	mount	3088	3076	5000
Link	mount	471	484	5000
MenuButton	mount	1502	1553	5000
MessageBar	mount	2199	2168	5000
Nav	mount	3378	3361	1000
OverflowSet	mount	1111	1107	5000
Panel	mount	2258	2235	1000
Persona	mount	1046	1051	1000
Pivot	mount	1484	1478	1000
PrimaryButton	mount	1362	1332	5000
Rating	mount	7917	7980	5000
SearchBox	mount	1345	1362	5000
Shimmer	mount	2576	2558	5000
Slider	mount	1975	2015	5000
SpinButton	mount	5203	5212	5000
Spinner	mount	446	443	5000
SplitButton	mount	3217	3223	5000
Stack	mount	538	554	5000
StackWithIntrinsicChildren	mount	2348	2355	5000
StackWithTextChildren	mount	5418	5401	5000
SwatchColorPicker	mount	11900	11974	5000
TagPicker	mount	2836	2748	5000
TeachingBubble	mount	98331	98773	5000
Text	mount	439	441	5000
TextField	mount	1457	1457	5000
ThemeProvider	mount	1227	1259	5000
ThemeProvider	virtual-rerender	668	634	5000
ThemeProvider	virtual-rerender-with-unmount	1943	1905	5000
Toggle	mount	814	821	5000
buttonNative	mount	129	139	5000

JustSlone · 2022-05-05T16:31:55Z

@TristanWatanabe I added the Do Not Merge label for you, remove it when this is ready to merge

This reverts commit 53995d6.

…22830)

move react-combobox

53995d6

TristanWatanabe self-assigned this May 4, 2022

TristanWatanabe added the Area: Build System label May 4, 2022

TristanWatanabe mentioned this pull request May 4, 2022

group vNext to common folder (as people will start check vNext) #22427

Closed

23 tasks

TristanWatanabe marked this pull request as ready for review May 4, 2022 16:00

TristanWatanabe requested review from a team, JustSlone, jurokapsiar and smhigley as code owners May 4, 2022 16:00

JustSlone approved these changes May 5, 2022

View reviewed changes

JustSlone added the Status: Do Not Merge 🚫 label May 5, 2022

Hotell approved these changes May 6, 2022

View reviewed changes

TristanWatanabe added 3 commits May 17, 2022 19:54

Revert "move react-combobox"

3bd6d11

This reverts commit 53995d6.

Merge branch 'master' into move-react-combobox

a446af5

move react-combobox

6dbc64d

TristanWatanabe removed the Status: Do Not Merge 🚫 label May 18, 2022

micahgodbolt approved these changes May 18, 2022

View reviewed changes

TristanWatanabe merged commit 3fee835 into microsoft:master May 18, 2022

TristanWatanabe deleted the move-react-combobox branch May 18, 2022 14:52

marwan38 pushed a commit to marwan38/fluentui that referenced this pull request Jun 13, 2022

(chore) Move react-combobox to react-components subfolder (microsoft#…

bee3e17

…22830)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

(chore) Move react-combobox to react-components subfolder #22830

(chore) Move react-combobox to react-components subfolder #22830
TristanWatanabe merged 4 commits intomicrosoft:masterfrom
TristanWatanabe:move-react-combobox

TristanWatanabe commented May 4, 2022 •

edited

Loading

Uh oh!

codesandbox-ci bot commented May 4, 2022 •

edited

Loading

Uh oh!

size-auditor bot commented May 4, 2022 •

edited

Loading

Uh oh!

fabricteam commented May 4, 2022 •

edited

Loading

Uh oh!

fabricteam commented May 4, 2022 •

edited

Loading

Uh oh!

fabricteam commented May 4, 2022 •

edited

Loading

Uh oh!

fabricteam commented May 4, 2022 •

edited

Loading

Uh oh!

JustSlone commented May 5, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

TristanWatanabe commented May 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Related Issue(s)

Uh oh!

codesandbox-ci bot commented May 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

size-auditor bot commented May 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Asset size changes

Uh oh!

fabricteam commented May 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf Analysis (@fluentui/react-components)

Uh oh!

fabricteam commented May 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Bundle size report

Uh oh!

fabricteam commented May 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf Analysis (@fluentui/react-northstar)

Uh oh!

fabricteam commented May 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf Analysis (@fluentui/react)

Uh oh!

JustSlone commented May 5, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

TristanWatanabe commented May 4, 2022 •

edited

Loading

codesandbox-ci bot commented May 4, 2022 •

edited

Loading

size-auditor bot commented May 4, 2022 •

edited

Loading

fabricteam commented May 4, 2022 •

edited

Loading

Perf Analysis (`@fluentui/react-components`)

fabricteam commented May 4, 2022 •

edited

Loading

fabricteam commented May 4, 2022 •

edited

Loading

Perf Analysis (`@fluentui/react-northstar`)

fabricteam commented May 4, 2022 •

edited

Loading

Perf Analysis (`@fluentui/react`)