chore(react-tree): delegate focus outline to layout components#29293
Merged
bsunderhus merged 1 commit intomicrosoft:masterfrom Oct 3, 2023
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
Focus outline is on the
TreeItemcomponent as this is the actual focused component, this is a problem on nested trees as theTreeItemwill contain inside of it a subtree with more tree itemsNew Behavior
Focus outline should be on the
TreeItemLayoutcomponent (although the actual focus is on theTreeItem), this way the focus will be visually on a single element even when focusing on a tree item with other tree items inside of it.Related Issue(s)