-
Notifications
You must be signed in to change notification settings - Fork 2.9k
feat: use default -2px offset for focus outline #33097
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
ling1726
wants to merge
1
commit into
microsoft:master
Choose a base branch
from
ling1726:react-tabster/feat/use-default-2px-offset
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
81 changes: 64 additions & 17 deletions
81
packages/react-components/react-menu/stories/src/Menu/MenuDefault.stories.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,20 +1,67 @@ | ||
| import * as React from 'react'; | ||
| import React from "react"; | ||
| import { | ||
| makeStyles, | ||
| mergeClasses, | ||
| FluentProvider, | ||
| webLightTheme, | ||
| Slider, | ||
| Switch, | ||
| Checkbox, | ||
| Button, | ||
| shorthands, | ||
| } from "@fluentui/react-components"; | ||
|
|
||
| import { Button, Menu, MenuTrigger, MenuList, MenuItem, MenuPopover } from '@fluentui/react-components'; | ||
| const useStyles = makeStyles({ | ||
| hidden: { | ||
| ...shorthands.overflow("hidden"), | ||
| }, | ||
| inlineFlex: { | ||
| display: "inline-flex", | ||
| }, | ||
| }); | ||
|
|
||
| export const Default = () => ( | ||
| <Menu> | ||
| <MenuTrigger disableButtonEnhancement> | ||
| <Button>Toggle menu</Button> | ||
| </MenuTrigger> | ||
| export const Default = () => { | ||
| const classes = useStyles(); | ||
|
|
||
| <MenuPopover> | ||
| <MenuList> | ||
| <MenuItem>New </MenuItem> | ||
| <MenuItem>New Window</MenuItem> | ||
| <MenuItem disabled>Open File</MenuItem> | ||
| <MenuItem>Open Folder</MenuItem> | ||
| </MenuList> | ||
| </MenuPopover> | ||
| </Menu> | ||
| ); | ||
| return ( | ||
| <FluentProvider theme={webLightTheme}> | ||
| <div className={classes.hidden}> | ||
| <h2>Cut cases:</h2> | ||
| <Slider /> | ||
| <br /> | ||
| <div className={mergeClasses(classes.hidden, classes.inlineFlex)}> | ||
| <Slider /> | ||
| </div> | ||
| <br /> | ||
| <Slider vertical /> | ||
| <br /> | ||
| <Switch defaultChecked /> | ||
| <br /> | ||
| <Checkbox defaultChecked /> | ||
|
|
||
| <hr /> | ||
| <h2>Invisible cases:</h2> | ||
| <div className={mergeClasses(classes.hidden, classes.inlineFlex)}> | ||
| <Slider vertical /> | ||
| </div> | ||
| <br /> | ||
| <div className={mergeClasses(classes.hidden, classes.inlineFlex)}> | ||
| <Switch defaultChecked /> | ||
| </div> | ||
| <br /> | ||
| <div className={mergeClasses(classes.hidden, classes.inlineFlex)}> | ||
| <Checkbox defaultChecked /> | ||
| </div> | ||
| <hr /> | ||
| <h2> | ||
| Reference (not using <code>createFocusOutlineStyle</code> for border): | ||
| </h2> | ||
| <Button>Reference</Button> | ||
| <br /> | ||
| <div className={mergeClasses(classes.hidden, classes.inlineFlex)}> | ||
| <Button>Reference</Button> | ||
| </div> | ||
| </div> | ||
| </FluentProvider> | ||
| ); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🕵🏾♀️ visual regressions to review in the fluentuiv9 Visual Regression Report
Avatar Converged 1 screenshots
Drawer 2 screenshots