feat(web-components): adopt focusgroup and its polyfill#35884
Merged
Conversation
📊 Bundle size report✅ No changes found |
|
Pull request demo site: URL |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…directional navigation
marchbox
force-pushed
the
users/machi/focusgroup
branch
from
c6832d2 to
370c7a1
Compare
… into users/machi/focusgroup
davatron5000
approved these changes
May 4, 2026
Contributor
davatron5000
left a comment
davatron5000
left a comment
There was a problem hiding this comment.
LGTM, had a couple questions around this.menuChildren, but doesn't need to block.
chrisdholt
reviewed
May 4, 2026
radium-v
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes bespoke code for directional navigation in favor of HTML’s
focusgroup, the new feature is polyfilled by@microsoft/focusgroup-polyfill.Noticeable changes:
tabindexmanagement codeFocusGroupfrom the polyfill in *.tsArrayItemCollectioninutils/focusgroup.ts