Skip to content

adopt focusgroup and its polyfill #35884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
marchbox wants to merge 6 commits into
base: master
Choose a base branch
from
+1,301 −352
Draft

adopt focusgroup and its polyfill #35884

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
cdb9d65
update radio-group to adopt focusgroup and its polyfill
marchbox Mar 19, 2026
64b7c09
fix polyfill call
marchbox Mar 19, 2026
a6e7bfe
Merge branch 'microsoft:master' into users/machi/focusgroup
marchbox Mar 19, 2026
7d6eed4
adopt focusgroup for menu-list and menu-item
marchbox Mar 19, 2026
cf2af6d
adopt focusgroup for tree and tree-item
marchbox Mar 23, 2026
a31475b
opt out items nested in a collapsed tree-item
marchbox Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/web-components/.storybook/preview-head.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,9 @@
);
Copy link

@github-actions github-actions bot Mar 19, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕵🏾‍♀️ visual changes to review in the Visual Change Report

vr-tests-web-components/Accordion 1 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests-web-components/Accordion. - Dark Mode.normal.chromium_1.png 3154 Changed
vr-tests-web-components/Avatar 1 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests-web-components/Avatar. - Dark Mode.normal.chromium_1.png 298 Changed
vr-tests-web-components/Badge 1 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests-web-components/Badge. - Dark Mode.normal.chromium.png 443 Changed
vr-tests-web-components/MenuList 3 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests-web-components/MenuList. - RTL.2nd selected.chromium.png 17 Changed
vr-tests-web-components/MenuList. - RTL.normal.chromium_1.png 39083 Changed
vr-tests-web-components/MenuList. - RTL.1st selected.chromium_2.png 39384 Changed
vr-tests-web-components/RadioGroup 1 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests-web-components/RadioGroup. - Dark Mode.2nd selected.chromium_3.png 119 Changed

window.CSS_ANCHOR_POLYFILL = applyPolyfill;
}

if (!('focusgroup' in HTMLElement.prototype)) {
const { polyfill } = await import('/focusgroup-polyfill.js');
window.FOCUSGROUP_POLYFILL = polyfill;
}
</script>
10 changes: 3 additions & 7 deletions packages/web-components/docs/web-components.api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3253,10 +3253,6 @@ export class MenuList extends FASTElement {
elementInternals: ElementInternals;
focus(): void;
handleChange(source: any, propertyName: string): void;
// @internal
handleFocusOut: (e: FocusEvent) => void;
// @internal (undocumented)
handleMenuKeyDown(e: KeyboardEvent): void | boolean;
protected isMenuItemElement: (el: Element) => el is HTMLElement;
// @internal (undocumented)
readonly isNestedMenu: () => boolean;
Expand All @@ -3265,7 +3261,7 @@ export class MenuList extends FASTElement {
// (undocumented)
protected itemsChanged(oldValue: HTMLElement[], newValue: HTMLElement[]): void;
// (undocumented)
protected menuItems: Element[] | undefined;
protected menuItems: HTMLElement[] | undefined;
// (undocumented)
protected setItems(): void;
}
Expand Down Expand Up @@ -3425,6 +3421,8 @@ export class RadioGroup extends FASTElement {
checkValidity(): boolean;
// @internal
clickHandler(e: MouseEvent): boolean | void;
// @internal (undocumented)
connectedCallback(): void;
disabled: boolean;
// @internal
protected disabledChanged(prev?: boolean, next?: boolean): void;
Expand All @@ -3438,8 +3436,6 @@ export class RadioGroup extends FASTElement {
focus(): void;
// @internal
focusinHandler(e: FocusEvent): boolean | void;
// @internal
focusoutHandler(e: FocusEvent): boolean | void;
static formAssociated: boolean;
// (undocumented)
formResetCallback(): void;
Expand Down
Loading
Loading