Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
Copy link
Copy Markdown

@github-actions github-actions bot Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕵🏾‍♀️ visual changes to review in the Visual Change Report

vr-tests-web-components/Avatar 2 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests-web-components/Avatar. - Dark Mode.normal.chromium_1.png 298 Changed
vr-tests-web-components/Avatar. - Dark Mode.normal.chromium.png 10380 Changed
vr-tests-web-components/MenuList 2 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests-web-components/MenuList. - RTL.2nd selected.chromium.png 17 Changed
vr-tests-web-components/MenuList. - RTL.2nd selected.chromium_3.png 38816 Changed

"type": "prerelease",
"comment": "fix: make setItems method on accordion protected to support extensibility",
"packageName": "@fluentui/web-components",
"email": "13071055+chrisdholt@users.noreply.github.com",
"dependentChangeType": "patch"
}
14 changes: 7 additions & 7 deletions packages/web-components/src/accordion/accordion.ts
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ export class Accordion extends FASTElement {
* then rebinds event listeners to each non-disabled item
* @returns {void}
*/
private setItems = (): void => {
protected setItems(): void {
if (this.slottedAccordionItems.length === 0) {
return;
}
Expand All @@ -128,13 +128,13 @@ export class Accordion extends FASTElement {
const expandedItem = this.findExpandedItem() as BaseAccordionItem;
this.setSingleExpandMode(expandedItem);
}
};
}

/**
* Checks if the accordion is in single expand mode
* @returns {boolean}
*/
private isSingleExpandMode(): boolean {
protected isSingleExpandMode(): boolean {
return this.expandmode === AccordionExpandMode.single;
}

Expand All @@ -143,7 +143,7 @@ export class Accordion extends FASTElement {
* @param expandedItem The item to expand in single expand mode
* @returns {void}
*/
private setSingleExpandMode(expandedItem: Element): void {
protected setSingleExpandMode(expandedItem: Element): void {
if (this.accordionItems.length === 0) {
return;
}
Expand All @@ -170,20 +170,20 @@ export class Accordion extends FASTElement {
* Removes event listeners from the previous accordion items
* @param oldValue An array of the previous accordion items
*/
private removeItemListeners = (oldValue: any): void => {
protected removeItemListeners(oldValue: any): void {
oldValue.forEach((item: HTMLElement, index: number) => {
Observable.getNotifier(item).unsubscribe(this, 'disabled');
Observable.getNotifier(item).unsubscribe(this, 'expanded');
item.removeEventListener('click', this.expandedChangedHandler);
});
};
}

/**
* Changes the expanded state of the accordion item
* @param evt Click event
* @returns
*/
private expandedChangedHandler: EventListener = (evt: Event): void => {
protected expandedChangedHandler: EventListener = (evt: Event): void => {
const item = evt.target as HTMLElement;

if (item instanceof BaseAccordionItem) {
Expand Down
Loading