Skip to content

Popup: Set tabindex to -1 to fix Esc on keydown event handler #7839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dzearing merged 3 commits into from
Jan 30, 2019
Merged

Popup: Set tabindex to -1 to fix Esc on keydown event handler #7839

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2106ba8
Correct issue where ESC does not work in Popups by adding tabindex to…
jhellesen Jan 29, 2019
69bc27a
Add changefile
jhellesen Jan 29, 2019
aede692
Add snapshot updates for popup z-index addition
jhellesen Jan 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions common/changes/office-ui-fabric-react/u-jehell-popup-tabindex_2019-01-29-21-05.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"packageName": "office-ui-fabric-react",
"comment": "Support ESC after clicking in Popup",
"type": "patch"
}
],
"packageName": "office-ui-fabric-react",
"email": "jehell@microsoft.com"
}
1 change: 1 addition & 0 deletions packages/office-ui-fabric-react/src/components/Callout/__snapshots__/Callout.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ exports[`Callout renders Callout correctly 1`] = `
"overflowY": undefined,
}
}
tabIndex={-1}
>
Content
</div>
Expand Down
2 changes: 2 additions & 0 deletions ...ges/office-ui-fabric-react/src/components/HoverCard/__snapshots__/HoverCard.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,7 @@ exports[`HoverCard renders ExpandingCard correctly 1`] = `
"overflowY": "hidden",
}
}
tabIndex={-1}
>
<div
onFocusCapture={[Function]}
Expand Down Expand Up @@ -295,6 +296,7 @@ exports[`HoverCard renders PlainCard correctly 1`] = `
"overflowY": undefined,
}
}
tabIndex={-1}
>
<div
onFocusCapture={[Function]}
Expand Down
1 change: 1 addition & 0 deletions packages/office-ui-fabric-react/src/components/Modal/__snapshots__/Modal.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ exports[`Modal renders Modal correctly 1`] = `
"overflowY": undefined,
}
}
tabIndex={-1}
>
<div
className=
Expand Down
1 change: 1 addition & 0 deletions packages/office-ui-fabric-react/src/components/Panel/__snapshots__/Panel.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ exports[`Panel renders Panel correctly 1`] = `
"overflowY": undefined,
}
}
tabIndex={-1}
>
<div
aria-hidden={false}
Expand Down
1 change: 1 addition & 0 deletions packages/office-ui-fabric-react/src/components/Popup/Popup.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ export class Popup extends BaseComponent<IPopupProps, IPopupState> {

return (
<div
tabIndex={-1}
ref={this._root}
{...getNativeProps(this.props, divProperties)}
className={className}
Expand Down
1 change: 1 addition & 0 deletions ...-ui-fabric-react/src/components/TeachingBubble/__snapshots__/TeachingBubble.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ exports[`TeachingBubble renders TeachingBubble correctly 1`] = `
"overflowY": "hidden",
}
}
tabIndex={-1}
>
<div>
<div
Expand Down
1 change: 1 addition & 0 deletions packages/office-ui-fabric-react/src/components/Tooltip/__snapshots__/Tooltip.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,7 @@ exports[`Tooltip renders default Tooltip correctly 1`] = `
"overflowY": undefined,
}
}
tabIndex={-1}
>
<div
role="tooltip"
Expand Down
1 change: 1 addition & 0 deletions ...ffice-ui-fabric-react/src/components/__snapshots__/Panel.HiddenOnDismiss.Example.tsx.shot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,7 @@ exports[`Component Examples renders Panel.HiddenOnDismiss.Example.tsx correctly
"overflowY": undefined,
}
}
tabIndex={-1}
>
<div
aria-hidden={false}
Expand Down