Merged
Conversation
Collaborator
|
Hi @jhellesen, thanks for your contribution. It looks like you're missing a change file, can you please run |
jhellesen
requested review from
Jahnp,
atneik,
joschect and
micahgodbolt
as code owners
|
leddie24
approved these changes
Feb 1, 2019
joschect
approved these changes
Feb 1, 2019
…c-react into u/jehell/popup-outline
Collaborator
|
@micahgodbolt @Jahnp @atneik , can you take a look at this PR at your earliest convenience please? Thanks! |
atneik
approved these changes
Feb 1, 2019
Member
|
Looks fine to me, my only request would be some screenshots |
Collaborator
|
Screenshot below of the unintended effect:
After screenshot is just our current state
|
micahgodbolt
approved these changes
Feb 4, 2019
Contributor
|
🎉 Handy links: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
#7839 fixed a keyboarding issue by adding a tabIndex to the Popup, but this change also introduced a blue outline around the Popup as a side effect when clicking the Popup in specific browsers such as Chrome. Note this does not happen in Edge.
This change removes the outline from the Popup to remove the unintended visual change introduced by #7839
Focus areas to test
Components using Popup - like Callout or Modal - and their visual appearance when clicked or when keyboarding.
Microsoft Reviewers: Open in CodeFlow