Focuszone: onActiveItemChanged now fires#7958
Merged
KevinTCoughlin merged 3 commits intomicrosoft:masterfrom Feb 12, 2019
dzearing:focuszone-active
Merged
Focuszone: onActiveItemChanged now fires#7958KevinTCoughlin merged 3 commits intomicrosoft:masterfrom dzearing:focuszone-active
KevinTCoughlin merged 3 commits intomicrosoft:masterfrom
dzearing:focuszone-active
Conversation
Contributor
|
Hello @cliffkoh! Because this pull request has the Do note that I've been instructed to only help merge pull-requests of this repository that have been opened for at least 8 hours, a condition that is not currently met. No worries though, I will be back when the time is right! 😉 |
Contributor
|
@dzearing This should merge in before our next publish, assuming build passes/you get approvals. |
cliffkoh
approved these changes
Feb 12, 2019
JasonGore
approved these changes
Feb 12, 2019
|
Size Auditor did not detect a change in bundle size for any component! |
KevinTCoughlin
pushed a commit
to KevinTCoughlin/office-ui-fabric-react
that referenced
this pull request
Feb 12, 2019
* Reverting focuszone activeelementchanged change, and adding a test. * Adding change file. * Remove lint issue
Contributor
|
🎉 Handy links: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
Reverting a change to avoid calling onActiveItemChanged too frequently, and adding tests to make sure it's called.
Microsoft Reviewers: Open in CodeFlow