FocusTrapZone: Fix zero tabbable element scenarios#8274
Merged
JasonGore merged 4 commits intomicrosoft:masterfrom Mar 12, 2019
JasonGore:jg/fix-ftz-no-tabbable
Merged
FocusTrapZone: Fix zero tabbable element scenarios#8274JasonGore merged 4 commits intomicrosoft:masterfrom JasonGore:jg/fix-ftz-no-tabbable
JasonGore merged 4 commits intomicrosoft:masterfrom
JasonGore:jg/fix-ftz-no-tabbable
Conversation
…ivs as visible with data-is-visible. Regression was caused by position: fixed, which makes offsetParent null for isElementVisible check.
JasonGore
requested review from
Jahnp,
Vitalius1,
atneik and
kkjeer
as code owners
dzearing
approved these changes
Mar 12, 2019
cliffkoh
approved these changes
Mar 12, 2019
|
Contributor
|
🎉 Handy links: |
This was referenced Apr 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
The last commit of #8216 actually broke one scenario: FocusTrapZone with 0 tabbable elements. This is because using
position: fixedcausesisElementVisibleutility to fail sinceoffsetParentis alwaysnullfor the bumpers. This PR fixes zero tabbable scenarios by adding thedata-is-visibleattribute to the bumpers.Focus areas to test
(optional)
Microsoft Reviewers: Open in CodeFlow