FocusTrapZone: Fix focus and blur callbacks#8404
Merged
JasonGore merged 2 commits intomicrosoft:masterfrom Mar 20, 2019
Merged
Conversation
Contributor
Author
|
FYI, this is was found because it introduced a regression in the office online ribbon, and it's a blocking issue |
|
JasonGore
approved these changes
Mar 20, 2019
Contributor
|
🎉 Handy links: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
$ npm run changeDescription of changes
#8216 broke the focus and blur callbacks on FocusTrapZone.
This PR makes sure to call the callbacks, if present in onRootFocus and onRootBlur handlers
Focus areas to test
Verified that the callbacks are being called again
Microsoft Reviewers: Open in CodeFlow