FocusZone: reduce global event listeners#8421
Merged
dzearing merged 4 commits intomicrosoft:masterfrom Mar 22, 2019
dzearing:focuszone-perf-tweak
Merged
FocusZone: reduce global event listeners#8421dzearing merged 4 commits intomicrosoft:masterfrom dzearing:focuszone-perf-tweak
dzearing merged 4 commits intomicrosoft:masterfrom
dzearing:focuszone-perf-tweak
Conversation
JasonGore
reviewed
Mar 21, 2019
| direction: FocusZoneDirection.bidirectional | ||
| }; | ||
|
|
||
| private static _allFocusZones = []; |
2 tasks
|
Contributor
|
🎉 Handy links: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a
FocusZoneis hosted, each outer zone creates a captured event listener for keydown presses, to adjust tab indexes when tab is pressed.This change reduces the listeners down to a single listener, therefore reducing the work being done when typing characters.
There should be no changes in behavior here; just less work being done when keydowns occur.
This was requested as a performance optimization from Outlook. Happy to help.
Microsoft Reviewers: Open in CodeFlow