Skip to content

FocusZone: track innerzones correctly.#8560

Merged
dzearing merged 3 commits intomicrosoft:masterfrom
dzearing:focuszone
Apr 2, 2019
Merged

FocusZone: track innerzones correctly.#8560
dzearing merged 3 commits intomicrosoft:masterfrom
dzearing:focuszone

Conversation

@dzearing
Copy link
Member

@dzearing dzearing commented Apr 2, 2019

Pull request checklist

Description of changes

The outer zones were not correctly filtering out inner zones.

Focus areas to test

Inner zones should now correctly update.

Microsoft Reviewers: Open in CodeFlow

@size-auditor
Copy link

size-auditor bot commented Apr 2, 2019

Bundle test Size (minified) Diff from master
Rating 82.284 kB ExceedsBaseline     42 bytes
MessageBar 170.228 kB ExceedsBaseline     42 bytes
DocumentCard 192.191 kB ExceedsBaseline     42 bytes
OverflowSet 55.324 kB ExceedsBaseline     42 bytes
Dialog 179.773 kB ExceedsBaseline     42 bytes
Pickers 253.372 kB ExceedsBaseline     42 bytes
Pivot 168.518 kB ExceedsBaseline     42 bytes
DetailsList 209.062 kB ExceedsBaseline     42 bytes
DatePicker 199.517 kB ExceedsBaseline     42 bytes
ContextualMenu 144.498 kB ExceedsBaseline     42 bytes
Nav 169.961 kB ExceedsBaseline     42 bytes
CommandBar 180.385 kB ExceedsBaseline     42 bytes
ComboBox 217.962 kB ExceedsBaseline     42 bytes
SearchBox 167.272 kB ExceedsBaseline     42 bytes
ExtendedPicker 85.311 kB ExceedsBaseline     42 bytes
SelectedItemsList 204.626 kB ExceedsBaseline     42 bytes
Panel 178.317 kB ExceedsBaseline     42 bytes
Dropdown 205.725 kB ExceedsBaseline     42 bytes
Facepile 188.733 kB ExceedsBaseline     42 bytes
ShimmeredDetailsList 219.886 kB ExceedsBaseline     42 bytes
FloatingPicker 215.108 kB ExceedsBaseline     42 bytes
SpinButton 173.557 kB ExceedsBaseline     42 bytes
FocusZone 28.991 kB ExceedsBaseline     42 bytes
Calendar 143.658 kB ExceedsBaseline     42 bytes
SwatchColorPicker 176.52 kB ExceedsBaseline     42 bytes
TeachingBubble 174.983 kB ExceedsBaseline     42 bytes
Button 172.589 kB ExceedsBaseline     42 bytes
Breadcrumb 178.791 kB ExceedsBaseline     42 bytes
Grid 163.625 kB ExceedsBaseline     42 bytes
GroupedList 119.133 kB ExceedsBaseline     42 bytes

ExceedsTolerance  Exceeds Tolerance     ExceedsBaseline  Exceeds Baseline     BelowBaseline  Below Baseline     1 kB = 1000 bytes

@dzearing dzearing merged commit 978929c into microsoft:master Apr 2, 2019
@dzearing dzearing deleted the focuszone branch April 2, 2019 01:53
@msft-github-bot
Copy link
Contributor

🎉office-ui-fabric-react@v6.164.2 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FocusZone can sometimes not set tab-index

2 participants