Skip to content

Remove aria-hidden from FocusTrapZone's bumpers #9019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jahnp merged 3 commits into from
May 9, 2019
Merged

Remove aria-hidden from FocusTrapZone's bumpers #9019

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e266f20
Remove aria-hidden
May 9, 2019
74af9fa
Update snapshots
May 9, 2019
154d2a8
Add rush change
May 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions common/changes/office-ui-fabric-react/panel-focus_2019-05-09-00-32.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"packageName": "office-ui-fabric-react",
"comment": "Fix ARIA issue in Surfaces",
"type": "patch"
}
],
"packageName": "office-ui-fabric-react",
"email": "anihan@microsoft.com"
}
1 change: 0 additions & 1 deletion packages/office-ui-fabric-react/src/components/FocusTrapZone/FocusTrapZone.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,6 @@ export class FocusTrapZone extends React.Component<IFocusTrapZoneProps, {}> impl
position: 'fixed' // 'fixed' prevents browsers from scrolling to bumpers when viewport does not contain them
},
tabIndex: disabled ? -1 : 0, // make bumpers tabbable only when enabled
'aria-hidden': true,
'data-is-visible': true
} as React.HTMLAttributes<HTMLDivElement>;

Expand Down
4 changes: 0 additions & 4 deletions ...ges/office-ui-fabric-react/src/components/HoverCard/__snapshots__/HoverCard.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,6 @@ exports[`HoverCard renders ExpandingCard correctly 1`] = `
onFocusCapture={[Function]}
>
<div
aria-hidden={true}
data-is-visible={true}
onFocus={[Function]}
style={
Expand Down Expand Up @@ -170,7 +169,6 @@ exports[`HoverCard renders ExpandingCard correctly 1`] = `
</div>
</div>
<div
aria-hidden={true}
data-is-visible={true}
onFocus={[Function]}
style={
Expand Down Expand Up @@ -329,7 +327,6 @@ exports[`HoverCard renders PlainCard correctly 1`] = `
onFocusCapture={[Function]}
>
<div
aria-hidden={true}
data-is-visible={true}
onFocus={[Function]}
style={
Expand All @@ -355,7 +352,6 @@ exports[`HoverCard renders PlainCard correctly 1`] = `
</div>
</div>
<div
aria-hidden={true}
data-is-visible={true}
onFocus={[Function]}
style={
Expand Down
6 changes: 0 additions & 6 deletions packages/office-ui-fabric-react/src/components/Modal/__snapshots__/Modal.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,6 @@ exports[`Modal renders Draggable Modal correctly 1`] = `
}
>
<div
aria-hidden={true}
data-is-visible={true}
onFocus={[Function]}
style={
Expand All @@ -153,7 +152,6 @@ exports[`Modal renders Draggable Modal correctly 1`] = `
Test Content
</div>
<div
aria-hidden={true}
data-is-visible={true}
onFocus={[Function]}
style={
Expand Down Expand Up @@ -306,7 +304,6 @@ exports[`Modal renders Modal correctly 1`] = `
onFocusCapture={[Function]}
>
<div
aria-hidden={true}
data-is-visible={true}
onFocus={[Function]}
style={
Expand All @@ -333,7 +330,6 @@ exports[`Modal renders Modal correctly 1`] = `
Test Content
</div>
<div
aria-hidden={true}
data-is-visible={true}
onFocus={[Function]}
style={
Expand Down Expand Up @@ -465,7 +461,6 @@ exports[`Modal renders Modeless Modal correctly 1`] = `
onFocusCapture={[Function]}
>
<div
aria-hidden={true}
data-is-visible={true}
onFocus={[Function]}
style={
Expand All @@ -492,7 +487,6 @@ exports[`Modal renders Modeless Modal correctly 1`] = `
Test Content
</div>
<div
aria-hidden={true}
data-is-visible={true}
onFocus={[Function]}
style={
Expand Down
2 changes: 0 additions & 2 deletions packages/office-ui-fabric-react/src/components/Panel/__snapshots__/Panel.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,6 @@ exports[`Panel renders Panel correctly 1`] = `
style={Object {}}
>
<div
aria-hidden={true}
data-is-visible={true}
onFocus={[Function]}
style={
Expand Down Expand Up @@ -404,7 +403,6 @@ exports[`Panel renders Panel correctly 1`] = `
</div>
</div>
<div
aria-hidden={true}
data-is-visible={true}
onFocus={[Function]}
style={
Expand Down
2 changes: 0 additions & 2 deletions ...-fabric-react/src/components/__snapshots__/CommandBar.CommandBarButtonAs.Example.tsx.shot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2119,7 +2119,6 @@ exports[`Component Examples renders CommandBar.CommandBarButtonAs.Example.tsx co
onFocusCapture={[Function]}
>
<div
aria-hidden={true}
data-is-visible={true}
onFocus={[Function]}
style={
Expand Down Expand Up @@ -2356,7 +2355,6 @@ exports[`Component Examples renders CommandBar.CommandBarButtonAs.Example.tsx co
</div>
</div>
<div
aria-hidden={true}
data-is-visible={true}
onFocus={[Function]}
style={
Expand Down
2 changes: 0 additions & 2 deletions ...ice-ui-fabric-react/src/components/__snapshots__/FocusTrapZone.Box.Click.Example.tsx.shot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ exports[`Component Examples renders FocusTrapZone.Box.Click.Example.tsx correctl
onFocusCapture={[Function]}
>
<div
aria-hidden={true}
data-is-visible={true}
onFocus={[Function]}
style={
Expand Down Expand Up @@ -401,7 +400,6 @@ exports[`Component Examples renders FocusTrapZone.Box.Click.Example.tsx correctl
</a>
</div>
<div
aria-hidden={true}
data-is-visible={true}
onFocus={[Function]}
style={
Expand Down
2 changes: 0 additions & 2 deletions ...es/office-ui-fabric-react/src/components/__snapshots__/FocusTrapZone.Box.Example.tsx.shot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,6 @@ exports[`Component Examples renders FocusTrapZone.Box.Example.tsx correctly 1`]
onFocusCapture={[Function]}
>
<div
aria-hidden={true}
data-is-visible={true}
onFocus={[Function]}
style={
Expand Down Expand Up @@ -583,7 +582,6 @@ exports[`Component Examples renders FocusTrapZone.Box.Example.tsx correctly 1`]
</a>
</div>
<div
aria-hidden={true}
data-is-visible={true}
onFocus={[Function]}
style={
Expand Down
2 changes: 0 additions & 2 deletions ...eact/src/components/__snapshots__/FocusTrapZone.Box.FocusOnCustomElement.Example.tsx.shot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,6 @@ exports[`Component Examples renders FocusTrapZone.Box.FocusOnCustomElement.Examp
onFocusCapture={[Function]}
>
<div
aria-hidden={true}
data-is-visible={true}
onFocus={[Function]}
style={
Expand Down Expand Up @@ -584,7 +583,6 @@ exports[`Component Examples renders FocusTrapZone.Box.FocusOnCustomElement.Examp
</a>
</div>
<div
aria-hidden={true}
data-is-visible={true}
onFocus={[Function]}
style={
Expand Down
2 changes: 0 additions & 2 deletions ...ice-ui-fabric-react/src/components/__snapshots__/FocusTrapZone.FocusZone.Example.tsx.shot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ exports[`Component Examples renders FocusTrapZone.FocusZone.Example.tsx correctl
onFocusCapture={[Function]}
>
<div
aria-hidden={true}
data-is-visible={true}
onFocus={[Function]}
style={
Expand Down Expand Up @@ -1094,7 +1093,6 @@ exports[`Component Examples renders FocusTrapZone.FocusZone.Example.tsx correctl
</div>
</div>
<div
aria-hidden={true}
data-is-visible={true}
onFocus={[Function]}
style={
Expand Down
10 changes: 0 additions & 10 deletions ...office-ui-fabric-react/src/components/__snapshots__/FocusTrapZone.Nested.Example.tsx.shot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,6 @@ exports[`Component Examples renders FocusTrapZone.Nested.Example.tsx correctly 1
onFocusCapture={[Function]}
>
<div
aria-hidden={true}
data-is-visible={true}
onFocus={[Function]}
style={
Expand Down Expand Up @@ -448,7 +447,6 @@ exports[`Component Examples renders FocusTrapZone.Nested.Example.tsx correctly 1
onFocusCapture={[Function]}
>
<div
aria-hidden={true}
data-is-visible={true}
onFocus={[Function]}
style={
Expand Down Expand Up @@ -774,7 +772,6 @@ exports[`Component Examples renders FocusTrapZone.Nested.Example.tsx correctly 1
onFocusCapture={[Function]}
>
<div
aria-hidden={true}
data-is-visible={true}
onFocus={[Function]}
style={
Expand Down Expand Up @@ -1096,7 +1093,6 @@ exports[`Component Examples renders FocusTrapZone.Nested.Example.tsx correctly 1
</button>
</div>
<div
aria-hidden={true}
data-is-visible={true}
onFocus={[Function]}
style={
Expand All @@ -1114,7 +1110,6 @@ exports[`Component Examples renders FocusTrapZone.Nested.Example.tsx correctly 1
onFocusCapture={[Function]}
>
<div
aria-hidden={true}
data-is-visible={true}
onFocus={[Function]}
style={
Expand Down Expand Up @@ -1436,7 +1431,6 @@ exports[`Component Examples renders FocusTrapZone.Nested.Example.tsx correctly 1
</button>
</div>
<div
aria-hidden={true}
data-is-visible={true}
onFocus={[Function]}
style={
Expand All @@ -1450,7 +1444,6 @@ exports[`Component Examples renders FocusTrapZone.Nested.Example.tsx correctly 1
</div>
</div>
<div
aria-hidden={true}
data-is-visible={true}
onFocus={[Function]}
style={
Expand All @@ -1468,7 +1461,6 @@ exports[`Component Examples renders FocusTrapZone.Nested.Example.tsx correctly 1
onFocusCapture={[Function]}
>
<div
aria-hidden={true}
data-is-visible={true}
onFocus={[Function]}
style={
Expand Down Expand Up @@ -1789,7 +1781,6 @@ exports[`Component Examples renders FocusTrapZone.Nested.Example.tsx correctly 1
</button>
</div>
<div
aria-hidden={true}
data-is-visible={true}
onFocus={[Function]}
style={
Expand All @@ -1803,7 +1794,6 @@ exports[`Component Examples renders FocusTrapZone.Nested.Example.tsx correctly 1
</div>
</div>
<div
aria-hidden={true}
data-is-visible={true}
onFocus={[Function]}
style={
Expand Down
2 changes: 0 additions & 2 deletions ...ffice-ui-fabric-react/src/components/__snapshots__/Panel.HiddenOnDismiss.Example.tsx.shot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,6 @@ exports[`Component Examples renders Panel.HiddenOnDismiss.Example.tsx correctly
style={Object {}}
>
<div
aria-hidden={true}
data-is-visible={true}
onFocus={[Function]}
style={
Expand Down Expand Up @@ -497,7 +496,6 @@ exports[`Component Examples renders Panel.HiddenOnDismiss.Example.tsx correctly
</div>
</div>
<div
aria-hidden={true}
data-is-visible={true}
onFocus={[Function]}
style={
Expand Down