Merged
Conversation
|
|
cvirendra
commented
Jun 21, 2019
Contributor
|
Component perf results:
|
|
Vitalius1
reviewed
Jun 21, 2019
common/changes/office-ui-fabric-react/checkForNoWrapFix_2019-06-21-05-14.json
Outdated
Show resolved
Hide resolved
Contributor
|
@JasonGore could you please take a look at this community contribution and help review. @cvirendra thank you for opening your first pull request on our repo! |
JasonGore
approved these changes
Jun 24, 2019
Member
JasonGore
left a comment
JasonGore
left a comment
There was a problem hiding this comment.
It's odd that the Fabric examples page doesn't show this behavior, but the Codepen does. I think it has something to do with the coordinates being non-zero for the Codepen.
I checked the solution locally using npm run codepen to be able to run the provided example and agree that the problem is that they are string comparisons, as well as parseFloat fixing the issue:
Thanks for the fix!
Contributor
|
🎉 Handy links: |
gingeroun
pushed a commit
to gingeroun/office-ui-fabric-react
that referenced
this pull request
Jul 5, 2019
* fix checkForNoWrap * add change file * revert unintented change * revert unintented change * add new line to change file * PR feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Description of changes
Convert strings to floating point before using.
Focus areas to test
(optional)
Microsoft Reviewers: Open in CodeFlow