Skip to content

Add imports for method parameters that are query parameters#3494

Merged
baywet merged 2 commits into
feature/typed-query-parametersfrom
fix/allow-query-param-imports
Oct 16, 2023
Merged

Add imports for method parameters that are query parameters#3494
baywet merged 2 commits into
feature/typed-query-parametersfrom
fix/allow-query-param-imports

Conversation

@Ndiritu
Copy link
Copy Markdown
Contributor

@Ndiritu Ndiritu commented Oct 13, 2023

Fixes the failing integration test in #3477 since PHP uses a factory method in request config classes that initialises the relevant query parameter object to improve the developer experience from importing multiple classes.

@Ndiritu Ndiritu self-assigned this Oct 13, 2023
@Ndiritu Ndiritu marked this pull request as ready for review October 13, 2023 21:48
@Ndiritu Ndiritu requested a review from a team as a code owner October 13, 2023 21:48
@Ndiritu Ndiritu changed the title Allow imports to be added for method parameters that are queryParams Add imports method parameters that are query parameters Oct 13, 2023
@Ndiritu Ndiritu changed the title Add imports method parameters that are query parameters Add imports for method parameters that are query parameters Oct 13, 2023
@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@baywet baywet merged commit 45cc251 into feature/typed-query-parameters Oct 16, 2023
@baywet baywet deleted the fix/allow-query-param-imports branch October 16, 2023 12:28
@baywet
Copy link
Copy Markdown
Member

baywet commented Oct 16, 2023

Thanks for putting this together!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants