Skip to content

Recreated .pylintrc to fix warning about suggestion-mode#7556

Open
WolfgangHG wants to merge 1 commit intomicrosoft:mainfrom
WolfgangHG:python_suggestionmode
Open

Recreated .pylintrc to fix warning about suggestion-mode#7556
WolfgangHG wants to merge 1 commit intomicrosoft:mainfrom
WolfgangHG:python_suggestionmode

Conversation

@WolfgangHG
Copy link
Copy Markdown
Contributor

The Python tests in CI report this warning:

.pylintrc:1:0: E0015: Unrecognized option found: suggestion-mode (unrecognized-option)

See e.g. https://github.com/microsoft/kiota/actions/runs/23412284458/job/68103912540?pr=7414#step:17:249

The switch "suggestion-mode" was removed in Pylint 4.0:
https://pylint.readthedocs.io/en/latest/whatsnew/4/4.0/index.html

Instead of removing this one line, I regenerated the file with this command:

pylint --generate-rcfile > .pylintrc

I think there were no changes, only a lot of additions.
But the new file introduced this parameter which did not exist in the old file:

# Minimum Python version to use for version dependent checks. Will default to
# the version used to run pylint.
py-version=3.14

As Github CI uses 3.11, I set the "py-version" to this version. Hope this is correct.

@WolfgangHG WolfgangHG requested a review from a team as a code owner April 1, 2026 18:57
Copy link
Copy Markdown
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

# the version used to run pylint.
# Use the version defined in github CI
# py-version=3.14
py-version=3.11
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

technically we "support" all the way down to 3.9
But that version has been EOL for quite some time now, 3.10 will be soon.

when we dropped support for 3.8, we didn't major bump. that's because the eco-system seems to be used to doing that.

microsoft/kiota-python#349

I suggest we set this one to 3.10, ensure in this PR all python versions for CI are aligned to that, and I'll make a PR in the other repo + release to drop support for 3.9.

What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants