Recreated .pylintrc to fix warning about suggestion-mode#7556
Open
WolfgangHG wants to merge 1 commit intomicrosoft:mainfrom
Open
Recreated .pylintrc to fix warning about suggestion-mode#7556WolfgangHG wants to merge 1 commit intomicrosoft:mainfrom
WolfgangHG wants to merge 1 commit intomicrosoft:mainfrom
Conversation
baywet
requested changes
Apr 2, 2026
| # the version used to run pylint. | ||
| # Use the version defined in github CI | ||
| # py-version=3.14 | ||
| py-version=3.11 |
Member
There was a problem hiding this comment.
technically we "support" all the way down to 3.9
But that version has been EOL for quite some time now, 3.10 will be soon.
when we dropped support for 3.8, we didn't major bump. that's because the eco-system seems to be used to doing that.
I suggest we set this one to 3.10, ensure in this PR all python versions for CI are aligned to that, and I'll make a PR in the other repo + release to drop support for 3.9.
What do you think?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Python tests in CI report this warning:
See e.g. https://github.com/microsoft/kiota/actions/runs/23412284458/job/68103912540?pr=7414#step:17:249
The switch "suggestion-mode" was removed in Pylint 4.0:
https://pylint.readthedocs.io/en/latest/whatsnew/4/4.0/index.html
Instead of removing this one line, I regenerated the file with this command:
I think there were no changes, only a lot of additions.
But the new file introduced this parameter which did not exist in the old file:
As Github CI uses 3.11, I set the "py-version" to this version. Hope this is correct.