Skip to content

fix: broken link in readme#221

Merged
matheusmaldaner merged 5 commits intomicrosoft:mainfrom
Lee-WonJun:patch-1
Jun 26, 2025
Merged

fix: broken link in readme#221
matheusmaldaner merged 5 commits intomicrosoft:mainfrom
Lee-WonJun:patch-1

Conversation

@Lee-WonJun
Copy link
Copy Markdown
Contributor

@Lee-WonJun Lee-WonJun commented Jun 25, 2025

  • The section name custom-client-configuration has been changed to Configuration.

  • It seems that each part was also modified, probably due to spaces or emojis. At the very least, navigation doesn’t work in my Edge/Chrome browser.

@husseinmozannar
Copy link
Copy Markdown
Contributor

The link is not broken for me? It will route to the subheading

@Lee-WonJun
Copy link
Copy Markdown
Contributor Author

The link is not broken for me? It will route to the subheading

It seems that the custom-client-configuration subheading has been removed — or am I mistaken? When I click the link, it doesn’t navigate to the specific section as expected.

@matheusmaldaner
Copy link
Copy Markdown
Contributor

Hi @Lee-WonJun, you are right, it also does not work for me.

I believe GitHub has a different way of interpreting the anchors (the links that connect the sections) than VS Code or other IDEs.

Some other anchors (in the quick navigation for example) are also broken for me on the deployed GitHub but work properly when testing locally. I will fix the remaining anchors when I get home and then we can merge this PR. Thank you for bringing this to our attention!

Copy link
Copy Markdown
Contributor

@matheusmaldaner matheusmaldaner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created a dummy GitHub repository to test these changes, and the anchors were properly fixed. Good to merge

@matheusmaldaner matheusmaldaner merged commit 6e85fe9 into microsoft:main Jun 26, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants