update network_name problem in env dind(docker in docker)

[dkzjq]

Title:

Add default parameter network_name to fix network issues in Docker-in-Docker environments

Description:

This merge request introduces a default parameter network_name to address network accessibility issues encountered in Docker-in-Docker (DinD) environments.

Problem:

In DinD setups, containers often face difficulties accessing other Docker containers due to network configuration problems. This can lead to failures in inter-container communication, impacting the functionality of the system.

2025-07-14 02:29:32.373 | WARNING  | magentic_ui.tools.playwright.browser.base_playwright_browser:connect_browser_with_retry:35 - Retrying connection in 5 seconds: : WebSocket error: connect ECONNREFUSED 127.0.0.1:33754
Call log:
  - <ws connecting> ws://127.0.0.1:33754/53ea5ca65d3cb334830e8201ed0da9f6
  -   - <ws error> ws://127.0.0.1:33754/53ea5ca65d3cb334830e8201ed0da9f6 error connect ECONNREFUSED 127.0.0.1:33754
  -   - <ws connect error> ws://127.0.0.1:33754/53ea5ca65d3cb334830e8201ed0da9f6 connect ECONNREFUSED 127.0.0.1:33754
  -   - <ws disconnected> ws://127.0.0.1:33754/53ea5ca65d3cb334830e8201ed0da9f6 code=1006 reason=

Solution:

By adding the network_name parameter, users can explicitly specify the Docker network to be used, ensuring proper connectivity between containers. This change provides a default value for network_name, simplifying configuration and improving reliability in DinD environments.

Changes:

Added a new parameter network_name with a default value.
Updated relevant documentation and examples to reflect the new parameter.
Tested the changes in a Docker-in-Docker environment to ensure proper functionality.
Testing:
Verified that containers can communicate with each other in a DinD setup using the specified network_name.
Ensured backward compatibility for setups that do not explicitly use the network_name parameter.

Impact:

This change improves the robustness of the system in Docker-in-Docker environments and does not affect existing setups that do not rely on the network_name parameter.

Notes:

Please review the implementation and provide feedback. Let me know if additional tests or adjustments are required.

[dkzjq]

@microsoft-github-policy-service agree

[husseinmozannar]

Thank you for your PR! I am reviewing things now

[Copilot]

Pull Request Overview

This PR adds support for configurable Docker network names to resolve connectivity issues in Docker-in-Docker (DinD) environments where containers cannot communicate using default network settings.

• Introduces a network_name parameter with default value "my-network" across browser configuration classes and utility functions
• Adds environment variable fallback (NETWORK_NAME) for flexible network configuration
• Updates frontend browser iframe component to dynamically determine server hostname instead of hardcoding "localhost"

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
vnc_docker_playwright_browser.py	Adds network_name parameter to browser configuration class
utils.py	Updates utility functions to accept and pass through network_name parameter
task_team.py	Passes network_name from config to browser resource creation
magentic_ui_config.py	Adds network_name field to main configuration class
plans.py	Adds OpenAI API configuration from environment variables
browser_iframe.tsx	Updates hostname resolution to use current location instead of hardcoded localhost

Comments suppressed due to low confidence (1)

src/magentic_ui/tools/playwright/browser/vnc_docker_playwright_browser.py:49

• Missing comma after the network_name parameter assignment to maintain consistency with other parameter assignments in the function call.

        network_name (str, optional): Docker network name for container communication. Default: `my-network`.

[husseinmozannar]

thank you for your contribution! I did some minor cleanup and merging, notably removed the NETWORK_NAME env variable as I worry the name of this environment variable might be used for other purposes by developers and create conflicts here, this can be set now in the config