Conversation
|
@husseinmozannar I pushed a commit to fix some uncaught bugs with Docker images. Can you delete your local magentic-ui docker images and confirm my changes work for you? In particular: Try uploading a file and asking about it to make sure the file surfer can open it. |
all good and working! |
There was a problem hiding this comment.
Pull Request Overview
This PR implements file upload functionality for the Magentic UI application. The implementation includes both backend and frontend changes to allow users to upload files that can be processed by AI agents during task execution.
Key changes:
- Added a new
/api/runs/{run_id}/uploadendpoint for file uploads - Enhanced the TeamManager to track uploaded files and exclude them from generated file detection
- Updated the frontend to support file uploads through the chat interface with improved file handling
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/magentic_ui/backend/web/routes/runs.py | Added upload endpoint for handling file uploads to run directories |
| src/magentic_ui/backend/utils/utils.py | Enhanced file processing to handle uploaded file references |
| src/magentic_ui/backend/teammanager/teammanager.py | Added uploaded file tracking to prevent them from being marked as generated |
| src/magentic_ui/tools/playwright/browser/vnc_docker_playwright_browser.py | Updated to use centralized browser image constant |
| src/magentic_ui/agents/file_surfer/_file_surfer.py | Updated to use centralized Python image constant and improved system prompts |
| src/magentic_ui/agents/_coder.py | Updated to use centralized Python image constant |
| frontend/src/components/views/chat/chatinput.tsx | Removed file validation restrictions and improved file handling UI |
| frontend/src/components/views/chat/chat.tsx | Added file upload processing and enhanced query handling |
| frontend/src/components/views/chat/runview.tsx | Updated to pass files parameter through component chain |
| frontend/src/components/views/chat/detail_viewer.tsx | Added files parameter to input response handler |
| frontend/src/components/views/chat/DetailViewer/fullscreen_overlay.tsx | Added files parameter to input response handler |
Comments suppressed due to low confidence (1)
src/magentic_ui/backend/teammanager/teammanager.py:375
- [nitpick] Using
_, _, _to ignore return values makes the code less readable and harder to maintain. Consider using more descriptive variable names liketeam, novnc_port, playwright_porteven if they're not used, or use a single_if all values are truly unused.
_, _, _ = await self._create_team(
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
tylerpayne
left a comment
There was a problem hiding this comment.
tested and looks good to me!
Close #128