Pull ghcr.io hosted Docker images instead of building#271
Pull ghcr.io hosted Docker images instead of building#271husseinmozannar merged 7 commits intomainfrom
Conversation
The python code is now only responsible for pulling the docker images from the Github Container Registry. Also added a convenience script for building all images locally if necessary
husseinmozannar
left a comment
There was a problem hiding this comment.
quick question: If I build the docker locally, will this pull from that local docker or will still force a download from ghcr on first time?
|
It will only pull if there is no matching image locally, so if you build
first then it will not pull. (And if you build after pull it replaces your
local image with the built version)
…On Thu, Jul 17, 2025 at 2:41 PM Hussein Mozannar ***@***.***> wrote:
***@***.**** commented on this pull request.
quick question: If I build the docker locally, will this pull from that
local docker or will still force a download from ghcr on first time?
—
Reply to this email directly, view it on GitHub
<#271 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABJIQ6OU5WDMLDQTQ6RXSDD3I7U4LAVCNFSM6AAAAACBX7YABGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTAMZQGYYTINJRHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull Request Overview
This PR transitions the Docker image management from building images locally to pulling pre-built images from GitHub Container Registry (ghcr.io/microsoft). The change simplifies the setup process by removing the need to build Docker images locally and eliminates the --rebuild-docker CLI option.
Key changes:
- Replaces
build_browser_image()andbuild_python_image()functions withpull_browser_image()andpull_python_image() - Updates Docker image references to use versioned images from GitHub Container Registry
- Removes the
--rebuild-dockerCLI option and related parameter passing - Adds a convenience script for building all images locally when needed
Reviewed Changes
Copilot reviewed 10 out of 21 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/magentic_ui/_docker.py | Core changes to replace build functions with pull functions and update image references to use registry URLs |
| src/magentic_ui/backend/cli.py | Removes --rebuild-docker option and updates function calls from build to pull |
| src/magentic_ui/_cli.py | Updates function imports and calls from build to pull operations |
| src/magentic_ui/tools/playwright/browser/vnc_docker_playwright_browser.py | Updates default image parameter to use new constant |
| docker/build-all.sh | New convenience script for building all Docker images locally |
| TROUBLESHOOTING.md | Updates troubleshooting documentation to reflect pull vs build approach |
| README.md | Updates documentation to reflect new pull-based workflow |
| .github/workflows/docker-build-push.yml | Updates Docker build context paths |
husseinmozannar
left a comment
There was a problem hiding this comment.
works! thanks for creating this! I will test it in a new environment and handle fixes in later PR
The python code is now only responsible for pulling the docker images from the Github Container Registry.
Also added a convenience script for building all images locally if necessary.
Removed the --rebuild-docker CLI option.
Resolves #76