Skip to content

Pull ghcr.io hosted Docker images instead of building#271

Merged
husseinmozannar merged 7 commits intomainfrom
ghcr-docker
Jul 17, 2025
Merged

Pull ghcr.io hosted Docker images instead of building#271
husseinmozannar merged 7 commits intomainfrom
ghcr-docker

Conversation

@tylerpayne
Copy link
Copy Markdown
Collaborator

The python code is now only responsible for pulling the docker images from the Github Container Registry.

Also added a convenience script for building all images locally if necessary.

Removed the --rebuild-docker CLI option.

Resolves #76

The python code is now only responsible for pulling the docker images from the Github Container Registry. Also added a convenience script for building all images locally if necessary
Copy link
Copy Markdown
Contributor

@husseinmozannar husseinmozannar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quick question: If I build the docker locally, will this pull from that local docker or will still force a download from ghcr on first time?

@tylerpayne
Copy link
Copy Markdown
Collaborator Author

tylerpayne commented Jul 17, 2025 via email

@husseinmozannar husseinmozannar requested a review from Copilot July 17, 2025 18:46

This comment was marked as outdated.

@husseinmozannar husseinmozannar requested a review from Copilot July 17, 2025 19:00
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR transitions the Docker image management from building images locally to pulling pre-built images from GitHub Container Registry (ghcr.io/microsoft). The change simplifies the setup process by removing the need to build Docker images locally and eliminates the --rebuild-docker CLI option.

Key changes:

  • Replaces build_browser_image() and build_python_image() functions with pull_browser_image() and pull_python_image()
  • Updates Docker image references to use versioned images from GitHub Container Registry
  • Removes the --rebuild-docker CLI option and related parameter passing
  • Adds a convenience script for building all images locally when needed

Reviewed Changes

Copilot reviewed 10 out of 21 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/magentic_ui/_docker.py Core changes to replace build functions with pull functions and update image references to use registry URLs
src/magentic_ui/backend/cli.py Removes --rebuild-docker option and updates function calls from build to pull
src/magentic_ui/_cli.py Updates function imports and calls from build to pull operations
src/magentic_ui/tools/playwright/browser/vnc_docker_playwright_browser.py Updates default image parameter to use new constant
docker/build-all.sh New convenience script for building all Docker images locally
TROUBLESHOOTING.md Updates troubleshooting documentation to reflect pull vs build approach
README.md Updates documentation to reflect new pull-based workflow
.github/workflows/docker-build-push.yml Updates Docker build context paths

Comment thread src/magentic_ui/_docker.py
Comment thread src/magentic_ui/_docker.py
Comment thread src/magentic_ui/_docker.py
Copy link
Copy Markdown
Contributor

@husseinmozannar husseinmozannar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works! thanks for creating this! I will test it in a new environment and handle fixes in later PR

@husseinmozannar husseinmozannar merged commit 8124415 into main Jul 17, 2025
9 checks passed
@husseinmozannar husseinmozannar deleted the ghcr-docker branch July 17, 2025 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Please host docker images on ghcr

3 participants