Fix passing of client configs in settings#309
Merged
husseinmozannar merged 5 commits intomainfrom Jul 31, 2025
Merged
Conversation
cheng-tan
requested changes
Jul 31, 2025
tylerpayne
reviewed
Jul 31, 2025
Collaborator
tylerpayne
left a comment
tylerpayne
left a comment
There was a problem hiding this comment.
Tests seemd to work but I did get this migration error:
2025-07-31 12:14:15.651 | INFO | magentic_ui.backend.database.db_manager:initialize_database:134 - Checking database schema...
2025-07-31 12:14:15.652 | INFO | magentic_ui.backend.database.schema_manager:ensure_schema_up_to_date:530 - Resetting migrations and updating to current schema...
2025-07-31 12:14:15.654 | INFO | magentic_ui.backend.database.schema_manager:ensure_schema_up_to_date:535 - Cleared alembic directory
2025-07-31 12:14:15.654 | INFO | magentic_ui.backend.database.schema_manager:ensure_schema_up_to_date:541 - Reset alembic version
2025-07-31 12:14:15.662 | INFO | magentic_ui.backend.database.schema_manager:_initialize_alembic:130 - Alembic initialization complete
INFO [alembic.runtime.migration] Context impl SQLiteImpl.
INFO [alembic.runtime.migration] Will assume non-transactional DDL.
INFO [alembic.autogenerate.compare] Detected added unique constraint None on '('user_id',)'
2025-07-31 12:14:15.692 | INFO | magentic_ui.backend.database.schema_manager:ensure_schema_up_to_date:553 - Generated fresh migration: 10b1fe714ca7
INFO [alembic.runtime.migration] Context impl SQLiteImpl.
INFO [alembic.runtime.migration] Will assume non-transactional DDL.
INFO [alembic.runtime.migration] Running upgrade -> 10b1fe714ca7, current_schema
2025-07-31 12:14:15.695 | ERROR | magentic_ui.backend.database.schema_manager:upgrade_schema:442 - Schema upgrade failed: No support for ALTER of constraints in SQLite dialect. Please refer to the batch mode feature which allows for SQLite migrations using a copy-and-move strategy.
cheng-tan
reviewed
Jul 31, 2025
Collaborator
cheng-tan
left a comment
cheng-tan
left a comment
There was a problem hiding this comment.
Also run into the migration error, and a small clean up
cheng-tan
approved these changes
Jul 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.