DI Refactor: Azure.Mcp.Tools.AzureMigrate#1909
Merged
Conversation
Co-authored-by: conniey <10136526+conniey@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Refactor Azure.Mcp.Tools.AzureMigrate to use constructor DI
DI Refactor: Azure.Mcp.Tools.AzureMigrate
Mar 3, 2026
Contributor
|
@conniey - I've validated it. Is this still a WIP or has it been completed? |
Co-authored-by: conniey <10136526+conniey@users.noreply.github.com>
Co-authored-by: conniey <10136526+conniey@users.noreply.github.com>
conniey
requested review from
alzimmermsft,
Copilot,
jongio,
msalaman,
sandeep-sen,
tmeschter and
wbreza
conniey
previously approved these changes
Mar 10, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors Azure Migrate tool commands to use constructor dependency injection instead of resolving services from CommandContext during execution.
Changes:
- Injected
IPlatformLandingZoneGuidanceServiceintoGetGuidanceCommandvia constructor and removedcontext.GetService<T>()usage. - Injected
IPlatformLandingZoneServiceandAzureMigrateProjectHelperintoRequestCommandvia constructor and adjusted helper usage accordingly. - Updated unit tests and added a server changelog entry for PR #1909.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tools/Azure.Mcp.Tools.AzureMigrate/tests/Azure.Mcp.Tools.AzureMigrate.UnitTests/PlatformLandingZone/RequestCommandTests.cs | Updates test construction of RequestCommand to pass DI dependencies directly. |
| tools/Azure.Mcp.Tools.AzureMigrate/tests/Azure.Mcp.Tools.AzureMigrate.UnitTests/PlatformLandingZone/GetGuidanceCommandTests.cs | Updates test construction of GetGuidanceCommand to pass the injected guidance service. |
| tools/Azure.Mcp.Tools.AzureMigrate/src/Commands/PlatformLandingZone/RequestCommand.cs | Switches RequestCommand to constructor injection and threads helper into create-project action handler. |
| tools/Azure.Mcp.Tools.AzureMigrate/src/Commands/PlatformLandingZone/GetGuidanceCommand.cs | Switches GetGuidanceCommand to constructor injection and removes service resolution from context. |
| servers/Azure.Mcp.Server/changelog-entries/1773163668700.yaml | Adds changelog entry documenting the DI refactor. |
…pendencies in RequestCommandTests Co-authored-by: conniey <10136526+conniey@users.noreply.github.com>
|
Hi @copilot. We've noticed that new changes have been pushed to this pull request. Because it is set to automatically merge, we've reset the approvals to allow the opportunity to review the updates. |
github-actions
Bot
dismissed
conniey’s stale review
Hi @conniey. We've noticed that new changes have been pushed to this pull request. Because it is set to automatically merge, we've reset the approvals to allow the opportunity to review the updates.
KarishmaGhiya
approved these changes
Mar 11, 2026
6 tasks
colbytimm
pushed a commit
to colbytimm/microsoft-mcp
that referenced
this pull request
Apr 20, 2026
* Initial plan * DI refactor: inject services via constructor in AzureMigrate commands Co-authored-by: conniey <10136526+conniey@users.noreply.github.com> * Add changelog entry for AzureMigrate DI refactor Co-authored-by: conniey <10136526+conniey@users.noreply.github.com> * Add PR number to changelog entry Co-authored-by: conniey <10136526+conniey@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: conniey <10136526+conniey@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IPlatformLandingZoneGuidanceServiceintoGetGuidanceCommandvia constructorIPlatformLandingZoneServiceandAzureMigrateProjectHelperintoRequestCommandvia constructorHandleCreateMigrateProjectActionAsyncto acceptAzureMigrateProjectHelperas parameternull!inRequestCommandTestswith a realAzureMigrateProjectHelperinstance backed by mockedISubscriptionServiceandITenantServiceOriginal prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.