Add mcp_redis_list to return details on Redis cache resources#760
Merged
sharedferret merged 1 commit intomicrosoft:mainfrom Oct 13, 2025
Merged
Conversation
sharedferret
requested review from
JonathanCrd,
KarishmaGhiya,
fanyang-mono,
jairmyree,
jongio and
vukelich
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR unifies Redis listing commands by replacing the separate mcp redis cache list and mcp redis cluster list commands with a single mcp redis list command. The unified command returns all Redis resources in a subscription including Azure Cache for Redis, Azure Redis Enterprise, and Azure Managed Redis resources, with access policy and database information flattened into the main response.
- Consolidates three separate list commands into one unified Redis resource listing command
- Flattens access policy assignments and databases into the main resource response
- Updates service layer to aggregate all Redis resource types into a single response model
Reviewed Changes
Copilot reviewed 33 out of 33 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| ResourceListCommandTests.cs | Adds comprehensive unit tests for the new unified Redis list command |
| DatabaseListCommandTests.cs | Removes tests for the deprecated database list command |
| ClusterListCommandTests.cs | Removes tests for the deprecated cluster list command |
| CacheListCommandTests.cs | Removes tests for the deprecated cache list command |
| AccessPolicyListCommandTests.cs | Removes tests for the deprecated access policy list command |
| RedisCommandTests.cs | Updates live tests to use the new unified command and response structure |
| RedisService.cs | Refactors service to aggregate all Redis resource types into a single method |
| IRedisService.cs | Simplifies interface to expose single unified list method |
| RedisSetup.cs | Updates DI registration to register only the unified command |
| RedisOptionDefinitions.cs | Simplifies option definitions for the unified approach |
| Resource.cs | Adds new unified resource model combining properties from all Redis types |
| ResourceListCommand.cs | Implements the new unified Redis list command |
| RedisJsonContext.cs | Updates JSON serialization context for the new response model |
Contributor
Author
|
@microsoft-github-policy-service agree company="Microsoft" |
sharedferret
force-pushed
the
redis-list-all-caches
branch
from
08daabb to
c246846
Compare
philon-msft
requested changes
Oct 10, 2025
github-project-automation
Bot
moved this from Untriaged
to In Progress
in Azure MCP Server
sharedferret
force-pushed
the
redis-list-all-caches
branch
from
c246846 to
1e5a3ff
Compare
philon-msft
requested changes
Oct 10, 2025
sharedferret
force-pushed
the
redis-list-all-caches
branch
from
1e5a3ff to
ea0cbce
Compare
philon-msft
approved these changes
Oct 10, 2025
joshfree
added
server-Azure.Mcp
Member
|
@sharedferret can you get this merged very early Monday AM? If not, let's hold off on changes until after the October stabilization period. |
Contributor
Author
|
I should be able to merge it tonight or early tomorrow.On Oct 12, 2025, at 11:20, Josh Free ***@***.***> wrote:joshfree left a comment (microsoft/mcp#760)
@sharedferret can you get this merged very early Monday AM? If not, let's hold off on changes until after the October stabilization period.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
alzimmermsft
approved these changes
Oct 13, 2025
7 tasks
colbytimm
pushed a commit
to colbytimm/microsoft-mcp
that referenced
this pull request
Dec 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR replaces the
mcp redis cache listandmcp redis cluster listcommands with a unifiedmcp redis listcommand to return data on all Redis resources in the subscription. Previously, themcp redis cache listreturned data on Azure Cache for Redis and Azure Redis Enterprise resources, andmcp redis cluster listreturned data on Azure Managed Redis resources. This change updates the list command to return AMR, Enterprise, and ACR resources in a single command.This change additionally flattens the responses from
mcp redis cache accesspolicy listandazmcp redis cluster database listintomcp redis list, so that the main list command returns all details for the Redis resources in a user's subscription as a single command.ToolDescriptionEvaluator scores for the unified command are as follows:
Test 288: 0.810504 (1st)
Test 289: 0.685128 (1st)
Test 290: 0.781228 (1st)
Test 291: 0.572767 (1st)
Test 292: 0.478070 (1st)
GitHub issue number?
#756
#757
Pre-merge Checklist
servers/Azure.Mcp.Server/CHANGELOG.mdand/orservers/Fabric.Mcp.Server/CHANGELOG.mdfor product changes (features, bug fixes, UI/UX, updated dependencies)servers/Azure.Mcp.Server/README.mdand/orservers/Fabric.Mcp.Server/README.mddocumentation/servers/Azure.Mcp.Server/docs/azmcp-commands.mdand/or/docs/fabric-commands.mdToolDescriptionEvaluatorand obtained a score of0.4or more and a top 3 ranking for all related test prompts/servers/Azure.Mcp.Server/docs/e2eTestPrompts.md