Added FlowDirection override to default ColorSpectrum style#10799
Added FlowDirection override to default ColorSpectrum style#10799Avid29 wants to merge 2 commits intomicrosoft:mainfrom
Conversation
|
Has there been any discussion or agreement on the issue at hand? |
@Jay-o-Way I have not seen one, no But I would gladly hash it out. Can we pull any other RTL language speakers in here? I can advocate with high confidence that Hebrew speakers would not expect this to be mirrored, and with slightly lower but still in fair confidence that Arabic is the same. |
|
As a native Hebrew speaker, RTL is about written language, and maybe a bit about layout related to text. Flipping anything else is gonna be highly frustrating, I'll give an example of such bug seen on some cellphone, the clock changes its layout on RTL, hence could write 55:11 Regarding the color palette, as one that uses a graphic tablet on a weekly basis. My muscle memory doesn't know if it's RTL or not, and do consider flipping it as a bug |
Zakariathr22
left a comment
There was a problem hiding this comment.
As a native Arabic speaker, I can agree that this element should be kept left-to-right; mirroring it does not provide any real benefit.
Co-authored-by: Zakaria Tahri <zakotahri@outlook.com>
Fixes
#10798
PR Type
Please check the type of change your PR introduces:
Description
Overrides the
FlowDirectionof theColorSpectrumto beLeftToRightregardless of parentFlowDirecitonCurrent Behavior
ColorSpectrum.FlowDirectionwill be inherited from its parent, resulting in a mirrored view whenRightToLeftNew Behavior
Unless explicitly set to
FlowDirection.RightToLeft, theColorSpectrumwill remainLeftToRightand the color spectrum will not be mirrored.Motivation and Context
Fixes #10798
How Has This Been Tested?
I have not tested the code with this change. I'd appreciate help setting up a test environment. This is a very simple change though.
Screenshots (if appropriate):