Skip to content

Initialize processor info memory to prevent garbage values#4871

Merged
nibanks merged 2 commits intomainfrom
zero-processor-info
Feb 28, 2025
Merged

Initialize processor info memory to prevent garbage values#4871
nibanks merged 2 commits intomainfrom
zero-processor-info

Conversation

@nibanks
Copy link
Collaborator

@nibanks nibanks commented Feb 27, 2025

Description

The PADDING field wasn't being set and apparently some code depended on that being explicitly zero.

Testing

Ci/CD & Locally

Documentation

N/A

@nibanks nibanks requested a review from a team as a code owner February 27, 2025 18:33
@nibanks nibanks added Bug: Platform A code bug in platform/TLS specific code. OS: Windows (User) labels Feb 27, 2025
@nibanks nibanks enabled auto-merge (squash) February 27, 2025 18:34
anrossi
anrossi previously approved these changes Feb 27, 2025
mtfriesen
mtfriesen previously approved these changes Feb 27, 2025
@nibanks nibanks dismissed stale reviews from mtfriesen and anrossi via 005a664 February 27, 2025 19:26
@codecov
Copy link

codecov bot commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.07%. Comparing base (7b2fbaf) to head (005a664).
Report is 20 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4871      +/-   ##
==========================================
- Coverage   87.43%   86.07%   -1.37%     
==========================================
  Files          56       56              
  Lines       17634    17630       -4     
==========================================
- Hits        15419    15175     -244     
- Misses       2215     2455     +240     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nibanks nibanks merged commit 9298cc8 into main Feb 28, 2025
389 of 391 checks passed
@nibanks nibanks deleted the zero-processor-info branch February 28, 2025 16:48
ProjectsByJackHe added a commit that referenced this pull request Mar 13, 2026
## Description

Following up on #4871 to
introduce a broader fix to address
#4870.

Makes pool allocs zero-init by default in user mode.

## Testing

Added an alloc test to test zero-inits.

## Documentation

N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug: Platform A code bug in platform/TLS specific code. OS: Windows (User)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants