Skip to content

Conversation

@anthonykim1
Copy link
Contributor

@anthonykim1 anthonykim1 commented Jan 12, 2026

Resolves: #842

@anthonykim1 anthonykim1 added this to the January 2026 milestone Jan 12, 2026
@anthonykim1 anthonykim1 self-assigned this Jan 12, 2026
@anthonykim1
Copy link
Contributor Author

Result of npm install:

Screenshot 2026-01-12 164914

Compile:
image

Is there anything else I should check before merging? @Tyriar

@anthonykim1 anthonykim1 requested a review from Tyriar January 13, 2026 00:50
@anthonykim1 anthonykim1 marked this pull request as ready for review January 13, 2026 00:50
@Tyriar Tyriar modified the milestones: January 2026, 1.2.0 Jan 13, 2026
@anthonykim1
Copy link
Contributor Author

anthonykim1 commented Jan 13, 2026

Time measured with Measure-Command { npx node-gyp rebuild }
Before start of each build, I have deleted the build folder via: Remove-Item -Recurse -Force .\build

Before removing winpty 59.361 second):

BeforeWinptyRemove2

After removing winpty (15.247 seconds):

BuildAfterRemove2

@Tyriar
Copy link
Member

Tyriar commented Jan 13, 2026

For me 47s before, 14s after 😍

@anthonykim1 anthonykim1 marked this pull request as draft January 13, 2026 17:14
anthonykim1 and others added 2 commits January 13, 2026 09:16
Co-authored-by: Daniel Imms <[email protected]>
Co-authored-by: Daniel Imms <[email protected]>
@anthonykim1 anthonykim1 reopened this Jan 13, 2026
@anthonykim1 anthonykim1 marked this pull request as ready for review January 13, 2026 22:33
@anthonykim1 anthonykim1 requested a review from Tyriar January 13, 2026 22:33
@anthonykim1 anthonykim1 enabled auto-merge January 14, 2026 16:57
@anthonykim1 anthonykim1 merged commit 4c5c671 into main Jan 14, 2026
14 of 16 checks passed
@anthonykim1 anthonykim1 deleted the anthonykim1/removeWinPty branch January 14, 2026 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove winpty support

4 participants