TraceParserGen generates non-compilable code for illegal identifiers

[Whathecode]

Event sources can be named more liberally than the resulting generated TraceEventParser class. E.g., an event source name can start with a number but the generated parser class can't.

Sidenote: overall, the TraceParserGen.exe tool isn't useful to me. Other than this bug report, I also run into #1351. And, if this tool is intended to be used, why not release it together with perfview releases?

[brianrob]

TraceParserGen is really about creating strongly-typed parsers, ideally for non-EventSource based providers. EventSources themselves emit their metadata into the event stream, and so this isn't strictly necessary. If you have a need for performance better than what you can get with the DynamicTraceEventParser, then this is a way you can go.

Ultimately, TraceParserGen really does need some work before it can take more investment. There have been a number of fixes put into it over the years, and they all seem to break sometihng. So, before we make any more changes to it, we need to produce a test-bed that can be used for regression testing. Unfortunately, this is not something that has made it to the top of the priority list and gotten completed. I'm afraid that's likely to continue until/unless someone takes this on in the community.