Skip to content

Fix hyperlink focus visibility in dark mode and improve keyboard navigation #2295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brianrob merged 5 commits into from
Sep 5, 2025
Merged

Fix hyperlink focus visibility in dark mode and improve keyboard navigation #2295

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f156005
Initial plan
Copilot Sep 4, 2025
8a286e9
Add focus visual style to hyperlinks in dark theme
Copilot Sep 4, 2025
0985b5b
Fix focus visual style for hyperlinks within RichTextBox FlowDocument
Copilot Sep 5, 2025
6d36f21
Remove menu icon hyperlinks and filter label from tab order
Copilot Sep 5, 2025
44dd5e4
Revert "Remove menu icon hyperlinks and filter label from tab order"
brianrob Sep 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/PerfView/Themes/DarkTheme.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2209,6 +2209,7 @@ SOFTWARE.
<Setter Property="OverridesDefaultStyle" Value="true" />
</Style>
<Style x:Key="{x:Type Hyperlink}" BasedOn="{StaticResource {x:Type Hyperlink}}" TargetType="{x:Type Hyperlink}">
<Setter Property="FocusVisualStyle" Value="{StaticResource FocusVisual}" />
<Style.Triggers>
<Trigger Property="IsMouseOver" Value="true">
<Setter Property="Foreground" Value="{StaticResource ControlBrightPrimaryColourBackground}" />
Expand All @@ -2222,6 +2223,7 @@ SOFTWARE.
</Style>

<Style x:Key="{x:Type Hyperlink}" TargetType="{x:Type Hyperlink}">
<Setter Property="FocusVisualStyle" Value="{StaticResource FocusVisual}" />
<Setter Property="Foreground" Value="{StaticResource ControlDefaultForeground}" />
<Setter Property="TextDecorations" Value="Underline" />
<Style.Triggers>
Expand Down