Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions src/TraceParserGen.Tests/ParserGenerationTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -911,5 +911,19 @@ public void VersionedEvent_EnumerateTemplatesHasEntryPerVersion()
}

#endregion

#region Leading digit provider name tests

[Fact]
public void LeadingDigitProvider_ClassNamePrefixedWithUnderscore()
{
string content = GenerateParserFromManifest("LeadingDigitProvider.manifest.xml");

// Provider "3Scale-ETW-Provider" → ToCSharpName → "_3ScaleETWProvider"
// C# identifiers cannot start with a digit, so an underscore is prepended.
Assert.Contains("public sealed class _3ScaleETWProviderTraceEventParser : TraceEventParser", content);
}

#endregion
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
<?xml version="1.0" encoding="utf-8"?>
<instrumentationManifest xmlns="http://schemas.microsoft.com/win/2004/08/events">
<instrumentation xmlns:xs="http://www.w3.org/2001/XMLSchema"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xmlns:win="http://manifests.microsoft.com/win/2004/08/windows/events">

<events xmlns="http://schemas.microsoft.com/win/2004/08/events">
<!-- Provider name starts with a digit to test ToCSharpName leading-digit fix -->
<provider name="3Scale-ETW-Provider"
guid="{DEADBEEF-DEAD-BEEF-DEAD-BEEFDEADBEEF}"
symbol="THREE_SCALE_ETW_PROVIDER"
messageFileName="3Scale.dll"
resourceFileName="3Scale.dll">

<tasks>
<task name="Request" value="1" />
</tasks>

<templates>
<template tid="RequestArgs">
<data name="Url" inType="win:UnicodeString" />
</template>
</templates>

<events>
<event value="1"
symbol="Request"
task="Request"
template="RequestArgs"
level="win:Informational" />
</events>

</provider>
</events>
</instrumentation>
</instrumentationManifest>
7 changes: 7 additions & 0 deletions src/TraceParserGen/TraceParserGen.cs
Original file line number Diff line number Diff line change
Expand Up @@ -1006,6 +1006,13 @@ public static string ToCSharpName(string input)

validName.Append(c);
}

// C# identifiers cannot start with a digit - prefix with underscore if needed.
if (validName.Length > 0 && Char.IsDigit(validName[0]))
{
validName.Insert(0, '_');
}

return validName.ToString();
}

Expand Down