test: rebase headless-shell/--headless=new/Edge tests #33350
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxschmitt
commented
Oct 29, 2024
tests/library/chromium/oopif.spec.ts
Outdated
| // @see https://github.com/GoogleChrome/puppeteer/issues/2548 | ||
| // https://google.com is isolated by default in Chromium embedder. | ||
| const browser = await browserType.launch({ headless: false }); | ||
| const browser = await browserType.launch(); |
Contributor
Author
There was a problem hiding this comment.
launch() internally will get its's headless value from the test-runner aka. browserType._defaultLaunchOptions.
mxschmitt
changed the title
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
pavelfeldman
approved these changes
Oct 29, 2024
mxschmitt
changed the title
mxschmitt
force-pushed
the
fix-tests22
branch
from
c77505b to
0649e8d
Compare
This comment has been minimized.
This comment has been minimized.
mxschmitt
commented
Oct 30, 2024
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Max Schmitt <[email protected]>
mxschmitt
force-pushed
the
fix-tests22
branch
from
d4d662c to
664fcbf
Compare
This comment has been minimized.
This comment has been minimized.
Contributor
Test results for "tests 1"36719 passed, 630 skipped Merge workflow run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests were failing after 5c0fdfe.