fix: dark-mode in UI Mode #33662
Merged
fix: dark-mode in UI Mode #33662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgozman
approved these changes
Nov 19, 2024
mxschmitt
force-pushed
the
fix-colorScheme-detectionp
branch
from
429f337 to
8576ee5
Compare
This comment has been minimized.
This comment has been minimized.
mxschmitt
force-pushed
the
fix-colorScheme-detectionp
branch
from
8576ee5 to
2bc70a9
Compare
This comment has been minimized.
This comment has been minimized.
dgozman
approved these changes
Nov 19, 2024
mxschmitt
added a commit
that referenced
this pull request
Nov 19, 2024
Contributor
Test results for "tests 1"1 flaky36946 passed, 650 skipped Merge workflow run. |
|
Hello. The issue is showing as fixed. How do I get the changes in my local? Please suggest. Thank you. |
Contributor
Author
|
|
|
Thank you @mxschmitt. |
|
Hello @mxschmitt, the issue is occuring again. |
Contributor
Author
|
Let's continue the discussion in #33660 (comment). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regressed in https://github.com/microsoft/playwright/pull/33350/files#diff-5e8771fb083ee3a9e97263f0a2c0b71134c58c29f7d208e5fd0341577e00c57dR166 instead of adjusting the call-side we should check inside the function if the passed value is truthy so it doesn't hit us in the future again.
Fixes #33660