Skip to content

Conversation

@Skn0tt
Copy link
Member

@Skn0tt Skn0tt commented Jun 20, 2025

There's no need to manipulate other browsers on this._playwright upon disconnect. And the !browser.contexts() clause was busted all along - I replaced it with a comment.

@Skn0tt Skn0tt self-assigned this Jun 20, 2025
@Skn0tt Skn0tt requested a review from dgozman June 20, 2025 13:35
@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

Test results for "tests 1"

1 failed
❌ [webkit-library] › library/browsercontext-viewport-mobile.spec.ts:87:5 › mobile viewport › should support window.orientation emulation @webkit-ubuntu-22.04-node18

4 flaky ⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-ubuntu-22.04-node18
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104:3 › should work with strict CSP policy @firefox-ubuntu-22.04-node18
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @ubuntu-latest-node22-1
⚠️ [webkit-library] › library/browsercontext-viewport-mobile.spec.ts:97:5 › mobile viewport › should fire orientationchange event @webkit-ubuntu-22.04-node18

39449 passed, 823 skipped
✔️✔️✔️

Merge workflow run.

@Skn0tt Skn0tt merged commit ed7e552 into microsoft:main Jun 23, 2025
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants