fix: get rid of url.parse in network code #36423
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxschmitt
commented
Jun 24, 2025
| // TODO: We should use HttpProxyAgent conditional on proxyOpts.protocol instead of always using CONNECT method. | ||
| return new HttpsProxyAgent(proxyOpts); | ||
| // TODO: switch to URL instance instead of legacy object once https-proxy-agent supports it. | ||
| return new HttpsProxyAgent(convertURLtoLegacyUrl(proxyOpts)); |
Contributor
Author
There was a problem hiding this comment.
We are still on and old https-proxy-agent version which uses url.parse internally if you pass a string - once we update we can remove the convertURLtoLegacyUrl function and pass the URL object over.
dgozman
approved these changes
Jun 24, 2025
Contributor
Test results for "tests 1"7 flaky39453 passed, 823 skipped Merge workflow run. |
This was referenced Jul 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code produced warnings before in Node.js 24.
Relates #36404