Open
Conversation
… quake window size on user event;
…rsor monitor & use the persisted size on initial activation;
This comment has been minimized.
This comment has been minimized.
metal-gabe
commented
Nov 24, 2025
| @@ -558,17 +569,36 @@ void AppHost::_initialResizeAndRepositionWindow(const HWND hwnd, til::rect propo | |||
|
|
|||
| if (_windowLogic.IsQuakeWindow()) | |||
Author
There was a problem hiding this comment.
The logic below was updated due to an issue where, after compiling/building, the very first activation would open on the main monitor (i.e. not on the current monitor that the cursor was on, which does not align with the behavior of the current release) at 50% (it wasn't using the stored size).
Author
|
@microsoft-github-policy-service agree |
metal-gabe
commented
Nov 24, 2025
| // Persist the new quake window size to ApplicationState | ||
| ApplicationState::SharedInstance().QuakeWindowSizePercent(static_cast<double>(sizePercent)); | ||
|
|
||
| #ifdef _DEBUG |
Author
There was a problem hiding this comment.
All debug logs that were added can be removed once this PR is ready for final review.
Author
|
@zadjii-msft I'm not sure if unit tests, documentation and/or the schema should be updated. Some guidance here would be appreciated. |
This comment has been minimized.
This comment has been minimized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Adds state persistence logic for the quake window to remember its size.
Note
This PR addresses the first item in the linked checklist below.
References and Relevant Issues
Implementation Checklist
Detailed Description of the Pull Request / Additional comments
WM_EXITSIZEMOVEcase toIslandWindowto check, calculate & store new quake window sizeApplicationStateproperty ofquakeWindowSizePercentto store & track resized values (defaults to 50%)AppHostto retrieve & store the saved sizeif (_windowLogic.IsQuakeWindow())block, the logic was updated to resolve an issue (see comments below)Validation Steps Performed
Manual Testing (document in PR):
Win+<backtick>)PR Checklist