Added rounded cursor shape option#19846
Conversation
…lledBox and roundedEmptyBox. Uses circular arc approximation in BackendD3D. Corner radius is set to 25% of cursor's smallest dimension. Closes issue microsoft#1446.
@microsoft-github-policy-service agree |
|
@microsoft-github-policy-service agree |
DHowett
left a comment
There was a problem hiding this comment.
- Please do not leave comments like
NEWaround the code. They're not going to be "new" any more if we choose to merge your code... - New cursor shapes need to be added to both the D3D backend and the D2D backend.
For the overall project direction: I am not sure this actually completes the request in #1446; users wanted to be able to change the radius, not to have a completely new different cursor shape which also doesn't support a configurable radius.
|
This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment. |
Summary of the Pull Request
Added roundedFilledBox and roundedEmptyBox cursor options. Uses circular arc approximation in BackendD3D. Corner radius is set to 25% of cursor's smallest dimension. Closes issue #1446.


References and Relevant Issues
issue #1446
Detailed Description of the Pull Request / Additional comments
Only implemented in BackendD3D, BackendD2D should be easy enough to add. Additional suggestions welcome!
Validation Steps Performed
Tested in both debug and release
PR Checklist