TestProperties breaking change

[dotMorten]

Description

A change was made for several classes to no longer inherit from TestProperty in this PR: #482

Steps to reproduce

This code used to compile/run:

DescriptionAttribute da = new DescriptionAttribute();
var attribute = (TestPropertyAttribute)da; //Invalid cast
var key = da.Key; //No longer exist
var value = da.Value; //No longer exist

Some are compile time, but 3rd party libraries that were compiled against an older version will get runtime errors.

Expected behavior

Continued binary and code compatibility across minor updates. If this was an intended change, they should be marked deprecated, and not removed until the next major version change (ie v2.0)

Actual behavior

Compile time or runtime errors.

[singhsarab]

@dotMoren I understand from OOPs perspective, it seems like a breaking change.
But thinking from the perspective of what this code is used for, this change seemed harmless.

• These are sealed classes, so cannot be extended.
• Users use these attributes only to decorate their unit test.
• I cannot think of the scenario where the user will actually try to create an object of the attribute and cast. Maybe we are missing it, can you please share some real life scenario where this is relevant.

I am actually fine bumping up the version for the adapter if we really think it breaks the users.
Also, this change has already been rolled out the pre-release version 1.4.0-beta and we haven't heard back on it.

[singhsarab]

@dotMorten Do you still have concerns around this one ?

[singhsarab]

@dotMorten Closing this issue for now, please let know if you have any concerns.