Fix nil pointer dereference in explainRedirectAndImpliedFormat during diagnostics#3377
Draft
Fix nil pointer dereference in explainRedirectAndImpliedFormat during diagnostics#3377
Conversation
…source file not found When neither a redirect file nor a source file exists for a given path, explainRedirectAndImpliedFormat would call methods on a nil *ast.SourceFile wrapped in an ast.HasFileName interface, causing a nil pointer dereference. This matches TypeScript's guard (file && explainIfFileIsRedirectAndImpliedFormat) in programDiagnostics.ts:229. Agent-Logs-Url: https://github.com/microsoft/typescript-go/sessions/be0523e7-9024-4d28-86bd-5992602b606c Co-authored-by: DanielRosenwasser <972891+DanielRosenwasser@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix nil pointer dereference during diagnostics request
Fix nil pointer dereference in explainRedirectAndImpliedFormat during diagnostics
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
explainRedirectAndImpliedFormatpanics whenGetSourceFileByPathreturns nil for a given path. The nil*ast.SourceFilegets assigned to anast.HasFileNameinterface (making it non-nil), thenfile.Path()dereferences the nil concrete value.TypeScript guards this with
file && explainIfFileIsRedirectAndImpliedFormat(...)inprogramDiagnostics.ts:229. The Go port was missing this check.sourceFileis nil, using the sameLoadOrStorecaching pattern as the rest of the function